perf: improve paragragh performance #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
bxcodec
reviewed
Sep 20, 2023
lorem_test.go
Outdated
| @@ -52,13 +52,15 @@ func TestFakeWord(t *testing.T) { | |||
|
|
|||
| func TestFakeSentence(t *testing.T) { | |||
| res := Sentence() | |||
| fmt.Println(res) | |||
There was a problem hiding this comment.
can remove this print please
bxcodec
reviewed
Sep 20, 2023
lorem_test.go
Outdated
| if res == "" || !strings.HasSuffix(res, ".") { | ||
| t.Error("Expected sentence") | ||
| } | ||
| } | ||
|
|
||
| func TestFakeParagraph(t *testing.T) { | ||
| res := Paragraph() | ||
| fmt.Println(res) |
There was a problem hiding this comment.
During the test, the results were printed to see if they were as expected. When I submitted the PR, I forgot to delete it. 😆
There was a problem hiding this comment.
can remove this please?
done
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 89.04% 89.16% +0.11%
==========================================
Files 12 12
Lines 1762 1781 +19
==========================================
+ Hits 1569 1588 +19
Misses 138 138
Partials 55 55
☔ View full report in Codecov by Sentry. |
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
improve paragragh performance.
before optimize
after optimize