Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: Country Info(#47) #50

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

vitaliy-paliy
Copy link
Contributor

@vitaliy-paliy vitaliy-paliy commented Mar 22, 2024

Implemented #47 + added more data fields. Got all the country data from here

@vitaliy-paliy vitaliy-paliy changed the title Add feature: Country Names(#47) Add feature: Country Info(#47) Mar 22, 2024
@vitaliy-paliy
Copy link
Contributor Author

cc @bxcodec

@rubemlrm
Copy link
Contributor

Hello @vitaliy-paliy good work that you did here. I will trigger the tests to see if it's all ok.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (6d0a05f) to head (61b71f0).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
address.go 85.71% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   89.01%   89.00%   -0.02%     
==========================================
  Files          13       13              
  Lines        1812     1828      +16     
==========================================
+ Hits         1613     1627      +14     
- Misses        142      143       +1     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxcodec bxcodec merged commit 181bd1b into go-faker:main Mar 29, 2024
2 checks passed
@bxcodec
Copy link
Contributor

bxcodec commented Mar 29, 2024

Thanks, @vitaliy-paliy, for the contribution!
And @rubemlrm for reviewing/triggering the test

@rubemlrm rubemlrm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants