Feature/event loop interop #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #198 * fixe weird edge case
The crash might be related to the golang wrapper of GL
need to implement Unregister, need to exposes: MarkExternalTextureFrameAvailable, RegisterExternalTexture in a good looking api
TODO: destroy the gl.GenTextures
Merged
pchampio
added a commit
that referenced
this pull request
Aug 2, 2019
pchampio
added a commit
that referenced
this pull request
Aug 2, 2019
pchampio
added a commit
that referenced
this pull request
Aug 4, 2019
pchampio
added a commit
that referenced
this pull request
Aug 4, 2019
pchampio
added a commit
that referenced
this pull request
Sep 3, 2019
* Texture support (#217) * Feature/event loop interop (#218) * Feature/callback messages (#220) * fix: remove initial WaitEvent now that we have implemented the proper event loop. Delete the first WaitEvent * lazy initialize go-gl/gl on first texture frame * align BinaryMessenger with *-channels BinaryMessenger: SendNoReply -> Send Send -> SendWithReply * change the priorityQueue to specifically contain embedder.FlutterTask's * Adds comments and renames internals. Also some re-ordering of init code. (#235) * Addressing comments & fix pointer warning * implement RunOnCurrentThread check using C call * Custom error codes on the plugin side (#238) Custom error codes on the plugin side * rely on LockOSThread to ensure engine task are run on the same thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicated of #215
Go implementation of https://github.com/flutter/engine/pull/9089/files
This feature is removing a deprecated engine function. For now, there is a tiny benefit of using
FlutterCustomTaskRunners, instead ofFlutterEngineFlushPendingTasksNow.Once the restriction evoked by @chinmaygarde comment is lift. I hope to remove all polling handler from the embedder.
To achieve true waiting, the UI must run on a separate thread. (android UIthread like). I don't thinks it's possible using GLFW.