Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Directory and File Picker #3

Closed
wants to merge 14 commits into from
Closed

Add Directory and File Picker #3

wants to merge 14 commits into from

Commits on May 12, 2019

  1. Add a directory picker

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    2d66d84 View commit details
    Browse the repository at this point in the history

  2. Return a more detailed error when the dialog picker cannot be opened

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    ddefbaa View commit details
    Browse the repository at this point in the history

  3. Return nil as the error when directory picker is successful

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    bbaae72 View commit details
    Browse the repository at this point in the history

  4. Add tests for directory picker

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    dc03496 View commit details
    Browse the repository at this point in the history

  5. Add support for picking regular files

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    ee390ea View commit details
    Browse the repository at this point in the history

  6. Add a readme

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    f5d622c View commit details
    Browse the repository at this point in the history

  7. Rename directory variable to file descriptor

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    4390a82 View commit details
    Browse the repository at this point in the history

  8. Update root README.md

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    759b7b9 View commit details
    Browse the repository at this point in the history

  9. Update go mod files

    @ryanleecode
    ryanleecode committed May 12, 2019
    Configuration menu
    Copy the full SHA
    a4dcf63 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Add newline to end of files that didn't have it

    @ryanleecode
    ryanleecode committed May 14, 2019
    Configuration menu
    Copy the full SHA
    5857fd8 View commit details
    Browse the repository at this point in the history

  2. Fix Readme naming errors 

     - Renames title from dialog_picker to file_picker as it is the name of package
- Corrects the go import statement to the correct one.
- Removes the parameters on the FilePickerPlugin
    @ryanleecode
    ryanleecode committed May 14, 2019
    Configuration menu
    Copy the full SHA
    b65a59d View commit details
    Browse the repository at this point in the history

  3. Remove VendorName and ApplicationName parameters from the plugin 

    - They aren't use by the plugin and are not mandatory to be set
    @ryanleecode
    ryanleecode committed May 14, 2019
    Configuration menu
    Copy the full SHA
    50162a1 View commit details
    Browse the repository at this point in the history

  4. Rename go.mod module name to file_picker

    @ryanleecode
    ryanleecode committed May 14, 2019
    Configuration menu
    Copy the full SHA
    961bc8e View commit details
    Browse the repository at this point in the history

  5. Fix missing string type annotation on title in dialog provider

    @ryanleecode
    ryanleecode committed May 14, 2019
    Configuration menu
    Copy the full SHA
    d3f05c6 View commit details
    Browse the repository at this point in the history