Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Add function to resolve short commit ID to full SHA1 #122

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Add function to resolve short commit ID to full SHA1 #122

merged 2 commits into from
Jun 12, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jun 5, 2018

Needed for go-gitea/gitea#4127

@lunny
Copy link
Member

lunny commented Jun 5, 2018

LGTM

@daviian
Copy link
Member

daviian commented Jun 8, 2018

@lafriks Can you add a test verifying that it really outputs "exit status 128" if the rev does not exist? My local git doesn't return that.

@lafriks
Copy link
Member Author

lafriks commented Jun 12, 2018

@daviian added tests for both cases (found and not found).
When running from console it will not contain exact text exit status 128, it will be just that exit status is 128. That I verified and works as expected.

@lafriks lafriks merged commit 466ac24 into go-gitea:master Jun 12, 2018
@lafriks lafriks deleted the feat/get_full_commit_id branch June 12, 2018 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants