fix canWriteAsMaintainer

go-gitea · Oct 9, 2024 · 0e83e04 · 0e83e04
1 parent bcb7884
commit 0e83e04
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/services/context/repo.go b/services/context/repo.go
@@ -1051,8 +1051,8 @@ func GitHookService() func(ctx *Context) {
 
 // canWriteAsMaintainer check if the doer can write to a branch as a maintainer
 func canWriteAsMaintainer(ctx *Context) bool {
-	// There is no need to check if the branch exists.
-	// If the branch does not exist, CanMaintainerWriteToBranch will return false.
-	branchName := getRefNameFromPath(ctx.Repo, ctx.PathParam("*"), func(_ string) bool { return true })
-	return issues_model.CanMaintainerWriteToBranch(ctx, ctx.Repo.Permission, branchName, ctx.Doer)
+	branchName := getRefNameFromPath(ctx.Repo, ctx.PathParam("*"), func(branchName string) bool {
+		return issues_model.CanMaintainerWriteToBranch(ctx, ctx.Repo.Permission, branchName, ctx.Doer)
+	})
+	return len(branchName) > 0
 }