Skip to content

Commit

Permalink
Fix some broken css (#23560) (#23567)
Browse files Browse the repository at this point in the history
Backport #23560 by @wxiaoguang

1. The "close" inside "modal" are likely broken for long time
    * There is no var called `--body-color`
    * There is no `fullscreen modal`
* The `.ui.modal > .close.inside` doesn't seem to match most icons. It
only matches a few like "fork-repo-modal" or "adopt repo". Other places
are just buggy code copied again and again.
2. Convert the legacy `&:hover` LESS syntax to CSS syntax

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <leon@kske.dev>
  • Loading branch information
3 people authored Mar 19, 2023
1 parent f5a98b0 commit 3f253b3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions web_src/css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -1173,10 +1173,8 @@ a.ui.card:hover,
border-color: var(--color-secondary);
}

.ui.modal > .close.inside,
.ui.fullscreen.modal > .close {
top: 11px; /* align modal close icon, for example admin notices */
color: var(--body-color);
.ui.modal > .close.inside {
color: var(--color-text);
}

.ui.basic.table > tbody > tr {
Expand Down
6 changes: 3 additions & 3 deletions web_src/css/code/linebutton.css
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
left: 0;
transform: translateX(-70%);
cursor: pointer;
}

&:hover {
color: var(--color-primary);
}
.code-line-button:hover {
color: var(--color-primary);
}

0 comments on commit 3f253b3

Please sign in to comment.