Skip to content

Commit

Permalink
add a comment of annoying Chrome crash for future developers, fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
wxiaoguang committed Mar 15, 2023
1 parent f0153a3 commit 696a120
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion web_src/js/features/aria.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function attachOneDropdownAria($dropdown) {

// if there is an active item, use it (the user is navigating between items)
// otherwise use the "selected" for combobox (for the last selected item)
let $active = $menu.find('> .item.active, > .item.selected');
const $active = $menu.find('> .item.active, > .item.selected');

// if there is an active item, use its id. if no active item or the dropdown is used as menu and is hidden, empty the active item
const activeId = $active.attr('id');
Expand Down
2 changes: 2 additions & 0 deletions web_src/js/features/common-global.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ export function initGlobalCommon() {
const $uiDropdowns = $('.ui.dropdown');

// do not init "custom" dropdowns, "custom" dropdowns are managed by their own code.
// NOTICE: some old Android Chrome browsers has a crash bug, this line triggers the bug,
// the browser crashes when users click the Issue Reaction Menu button ("return" before this line, no crash. after, crash)
$uiDropdowns.filter(':not(.custom)').dropdown({fullTextSearch: 'exact'});

// The "jump" means this dropdown is mainly used for "menu" purpose,
Expand Down

0 comments on commit 696a120

Please sign in to comment.