Skip to content

Commit

Permalink
Fixed lint warnings in Grafana raised by Mixtool (#22486)
Browse files Browse the repository at this point in the history
This PR introduces a few minor changes to the gitea-monitoring-mixin,
specifically linting issues raised by
[Mixtool](https://github.com/monitoring-mixins/mixtool):
- Query selectors using `job` and `instance` have been update to allow
multi-select
- Added missing attributes to `job` and `instance` template

As this change is very minor I haven't created an issue, but please let
me know if you'd like me to do so. According to the guidelines, it
seemed to only be for larger designs :)
  • Loading branch information
Dasomeone authored Jan 17, 2023
1 parent 21c91b7 commit 7a0f2fb
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions contrib/gitea-monitoring-mixin/dashboards/overview.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ local addIssueLabelsOverrides(labels) =

grafanaDashboards+:: {

local giteaSelector = 'job="$job", instance="$instance"',
local giteaSelector = 'job=~"$job", instance=~"$instance"',
local giteaStatsPanel =
grafana.statPanel.new(
'Gitea stats',
Expand Down Expand Up @@ -399,25 +399,31 @@ local addIssueLabelsOverrides(labels) =
.addTemplate(
{
hide: 0,
label: null,
label: 'job',
name: 'job',
options: [],
datasource: '$datasource',
query: 'label_values(gitea_organizations, job)',
refresh: 1,
regex: '',
type: 'query',
multi: true,
allValue: '.+'
},
)
.addTemplate(
{
hide: 0,
label: null,
label: 'instance',
name: 'instance',
options: [],
datasource: '$datasource',
query: 'label_values(gitea_organizations{job="$job"}, instance)',
refresh: 1,
regex: '',
type: 'query',
multi: true,
allValue: '.+'
},
)
.addTemplate(
Expand Down

0 comments on commit 7a0f2fb

Please sign in to comment.