as per review - add fail handler and simplify result checker

Signed-off-by: Andrew Thornton <art27@cantab.net>
go-gitea · Nov 21, 2021 · b4affc2 · b4affc2
1 parent 0b1afca
commit b4affc2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/web_src/js/features/repo-diff.js b/web_src/js/features/repo-diff.js
@@ -94,13 +94,15 @@ export function initRepoDiffShowMore() {
       type: 'GET',
       url,
     }).done((resp) => {
-      if (!resp || resp.html === '' || resp.empty) {
+      if (!resp) {
         $('#diff-show-more-files, #diff-show-more-files-stats').removeClass('disabled');
         return;
       }
       $('#diff-too-many-files-stats').remove();
       $('#diff-files').append($(resp).find('#diff-files li'));
       $('#diff-incomplete').replaceWith($(resp).find('#diff-file-boxes').children());
+    }).fail(() => {
+      $('#diff-show-more-files, #diff-show-more-files-stats').removeClass('disabled');
     });
   });
   $(document).on('click', 'a.diff-show-more-button', (e) => {
@@ -118,12 +120,14 @@ export function initRepoDiffShowMore() {
       type: 'GET',
       url,
     }).done((resp) => {
-      if (!resp || resp.html === '' || resp.empty) {
+      if (!resp) {
         $target.removeClass('disabled');
         return;
       }
 
       $target.parent().replaceWith($(resp).find('#diff-file-boxes .diff-file-body .file-body').children());
+    }).fail(() => {
+      $target.removeClass('disabled');
     });
   });
 }