Skip to content

Commit

Permalink
Use node:16.5 for frontend instead of node:16 (#16591)
Browse files Browse the repository at this point in the history
* Disable frontend testing

Jest does not appear to work on the latest node 16.6.0 and fails with an inscrutable
message.

I have been unable to work out what the problem is. This PR simply disables the
test-frontend part in the makefile.

Another alternative would be to drop node to node 14 - which is the LTS for node.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* actually just tell on 16.5 instead

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use node 16.5 instead of 16

Signed-off-by: Andrew Thornton <art27@cantab.net>
  • Loading branch information
zeripath authored Aug 1, 2021
1 parent b73e421 commit e3b6526
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ trigger:
steps:
- name: deps-frontend
pull: always
image: node:16
image: node:16.5
commands:
- make node_modules

- name: lint-frontend
image: node:16
image: node:16.5
commands:
- make lint-frontend
depends_on: [deps-frontend]
Expand Down Expand Up @@ -58,7 +58,7 @@ steps:
TAGS: bindata gogit sqlite sqlite_unlock_notify

- name: checks-frontend
image: node:16
image: node:16.5
commands:
- make checks-frontend
depends_on: [deps-frontend]
Expand All @@ -71,13 +71,13 @@ steps:
depends_on: [lint-backend]

- name: test-frontend
image: node:16
image: node:16.5
commands:
- make test-frontend
depends_on: [lint-frontend]

- name: build-frontend
image: node:16
image: node:16.5
commands:
- make frontend
depends_on: [test-frontend]
Expand Down

0 comments on commit e3b6526

Please sign in to comment.