Ignore empty avatars in v115.go (#9520)

* Ignore empty avatars * fixup! Ignore empty avatars
go-gitea · Dec 27, 2019 · e64880e · e64880e
1 parent 4acca9d
commit e64880e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/models/migrations/v115.go b/models/migrations/v115.go
@@ -47,7 +47,10 @@ func renameExistingUserAvatarName(x *xorm.Engine) error {
 		for _, user := range users {
 			oldAvatar := user.Avatar
 
-			if _, err := os.Stat(filepath.Join(setting.AvatarUploadPath, oldAvatar)); err != nil {
+			if stat, err := os.Stat(filepath.Join(setting.AvatarUploadPath, oldAvatar)); err != nil || !stat.Mode().IsRegular() {
+				if err == nil {
+					err = fmt.Errorf("Error: \"%s\" is not a regular file", oldAvatar)
+				}
 				log.Warn("[user: %s] os.Stat: %v", user.LowerName, err)
 				// avatar doesn't exist in the storage
 				// no need to move avatar and update database