Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [API ] Get Commits of a PullRequest #10918

Closed
6543 opened this issue Apr 1, 2020 · 6 comments · Fixed by #16300
Closed

[Feature] [API ] Get Commits of a PullRequest #10918

6543 opened this issue Apr 1, 2020 · 6 comments · Fixed by #16300
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.15.0

Comments

@6543
Copy link
Member

6543 commented Apr 1, 2020

api witch only return commits of a PullRequest - same as list on https://gitea/<user>/<repo>/pulls/<333>/commits shows

proposal: add GET /repos/{owner}/{repo}/pulls/{index}/commits

ToDo:

  • look if GitHub v3 API has something similar
@6543
Copy link
Member Author

6543 commented Apr 1, 2020

needed for GitNex: https://gitea.com/gitnex/GitNex/issues/332

@6543
Copy link
Member Author

6543 commented Apr 1, 2020

It's similar to #10871 so they could share some code ...

@stale
Copy link

stale bot commented May 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 31, 2020
@6543
Copy link
Member Author

6543 commented Jun 3, 2020

ping

@stale stale bot removed the issue/stale label Jun 3, 2020
@AndrewBezold AndrewBezold mentioned this issue Jul 1, 2020
Closed
@stale
Copy link

stale bot commented Aug 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 2, 2020
@6543
Copy link
Member Author

6543 commented Aug 2, 2020

stale just look at #12118 ;)

@stale stale bot removed the issue/stale label Aug 2, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Sep 5, 2020
@6543 6543 added this to the 1.15.0 milestone Apr 1, 2021
@sebastian-sauer sebastian-sauer mentioned this issue Jun 29, 2021
Merged
sebastian-sauer added a commit to sebastian-sauer/gitea that referenced this issue Jun 29, 2021
@sebastian-sauer @AndrewBezold
Add API to get commits of PR
8e06bb5 
fixes go-gitea#10918

Co-authored-by: Andrew Bezold <andrew.bezold@gmail.com>
6543 added a commit that referenced this issue Jul 2, 2021
@sebastian-sauer @AndrewBezold @6543
Add API to get commits of PR (#16300)
92328a3 
* Add API to get commits of PR

fixes #10918

Co-authored-by: Andrew Bezold <andrew.bezold@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@sebastian-sauer @AndrewBezold
@6543 @AbdulrhmnGhanem
Add API to get commits of PR (go-gitea#16300)
6b7166a 
* Add API to get commits of PR

fixes go-gitea#10918

Co-authored-by: Andrew Bezold <andrew.bezold@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.15.0
1 participant
@6543