Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] expose review comments link as on normal comments #11226

Closed
6543 opened this issue Apr 27, 2020 · 4 comments
Closed

[Enhancement] expose review comments link as on normal comments #11226

6543 opened this issue Apr 27, 2020 · 4 comments
Labels
issue/stale topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Apr 27, 2020

Gitea version: 0e799c2 (v1.12.0-dev)

normal comments can be linked via: https://gitea/user/repo/pulls/123#issuecomment-123456 where 123456 is the commentID

make same for reviews
@6543
Copy link
Member Author

6543 commented Apr 27, 2020

usefull for #11224 too

@guillep2k guillep2k added the type/enhancement An improvement of existing functionality label Apr 28, 2020
@6543 6543 changed the title [feature] make review comments linkable as normal comments [Enhancement] make review comments linkable as normal comments Apr 29, 2020
@6543
Copy link
Member Author

6543 commented Apr 29, 2020

ok it actuarly works but there is no link in the UI to it as with other comments

@6543 6543 changed the title [Enhancement] make review comments linkable as normal comments [Enhancement] expose review comments link as on normal comments Apr 29, 2020
@guillep2k guillep2k added the topic/ui Change the appearance of the Gitea UI label May 2, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 3, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Jul 18, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/stale topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guillep2k @6543