API: Add pull review endpoints #11224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This comment has been minimized.
This comment has been minimized.
6543
commented
Apr 27, 2020
lafriks
reviewed
Apr 29, 2020
lafriks
reviewed
Apr 29, 2020
lafriks
reviewed
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #11224 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 607 607
Lines 86807 86807
=======================================
Hits 37995 37995
Misses 44120 44120
Partials 4692 4692 Continue to review full report at Codecov.
|
lafriks
approved these changes
Apr 30, 2020
GiteaBot
added
lgtm/need 1
davidsvantesson
suggested changes
May 1, 2020
Co-authored-by: David Svantesson <davidsvantesson@gmail.com>
davidsvantesson
approved these changes
May 1, 2020
GiteaBot
added
lgtm/done
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* API: Added pull review read only endpoints * Update Structs, move Conversion, Refactor * refactor * lint & co * fix lint + refactor * add new Review state, rm unessesary, refacotr loadAttributes, convert patch to diff * add DeletePullReview * add paggination * draft1: Create & submit review * fix lint * fix lint * impruve test * DONT use GhostUser for loadReviewer * expose comments_count of a PullReview * infent GetCodeCommentsCount() * fixes * fix+impruve * some nits * Handle Ghosts 👻 * add TEST for GET apis * complete TESTS * add HTMLURL to PullReview responce * code format as per @lafriks * update swagger definition * Update routers/api/v1/repo/pull_review.go Co-authored-by: David Svantesson <davidsvantesson@gmail.com> * add comments Co-authored-by: Thomas Berger <loki@lokis-chaos.de> Co-authored-by: David Svantesson <davidsvantesson@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /repos/:owner/:repo/pulls/:pull_number/reviewsListPullReviewsGET /repos/:owner/:repo/pulls/:pull_number/reviews/:review_idGetPullReviewGET /repos/:owner/:repo/pulls/:pull_number/reviews/:review_id/commentsGetPullReviewCommentsPOST /repos/:owner/:repo/pulls/:pull_number/reviewsCreatePullReviewPOST /repos/:owner/:repo/pulls/:pull_number/reviews/:review_idSubmitPullReviewDELETE /repos/:owner/:repo/pulls/:pull_number/reviews/:review_idDeletePullReviewToDo:
take things of #10005
and finish it ...
close #5733
close #10005