Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New user recommended setting password question #11554

Closed
2 of 7 tasks
JaneYork opened this issue May 22, 2020 · 1 comment · Fixed by #11600
Closed
2 of 7 tasks

New user recommended setting password question #11554

JaneYork opened this issue May 22, 2020 · 1 comment · Fixed by #11600
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.12.0

Comments

@JaneYork
Copy link

  • Gitea version (or commit ref): 1.12
  • Git version: 2.26.2
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

The newly created user checked "recommended password setting". However, after the user has changed the password when logging in, he/she jumps to the event page and cannot open it. The diagram below:
the demo url like this:https://domain.com/user/events
dont tell is session??
@zeripath @GiteaBot
...

Screenshots

image
@zeripath
Copy link
Contributor

Oh interesting! Why does it do that?!

zeripath added a commit to zeripath/gitea that referenced this issue May 24, 2020
@zeripath
When must change password only show Signout
1b85c88 
When "Must Change Password" simplify the navbar header to only show the
signout button as all other links will redirect back. This prevents the
notifications icon from showing preventing initialization of the
event-source and hence preventing redirect_to being set, however in
addition do not set the redirect_to cookie if we are looking at the
/user/events page.

Fix go-gitea#11554

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue May 24, 2020
Merged
@zeripath zeripath added this to the 1.12.0 milestone May 24, 2020
@zeripath zeripath added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels May 24, 2020
zeripath added a commit that referenced this issue May 26, 2020
@zeripath
When must change password only show Signout (#11600)
a00974c 
When "Must Change Password" simplify the navbar header to only show the
signout button as all other links will redirect back. This prevents the
notifications icon from showing preventing initialization of the
event-source and hence preventing redirect_to being set, however in
addition do not set the redirect_to cookie if we are looking at the
/user/events page.

Fix #11554

Signed-off-by: Andrew Thornton <art27@cantab.net>
guillep2k pushed a commit to guillep2k/gitea that referenced this issue May 26, 2020
@zeripath @guillep2k
When must change password only show Signout (go-gitea#11600)
e6fa32b 
When "Must Change Password" simplify the navbar header to only show the
signout button as all other links will redirect back. This prevents the
notifications icon from showing preventing initialization of the
event-source and hence preventing redirect_to being set, however in
addition do not set the redirect_to cookie if we are looking at the
/user/events page.

Fix go-gitea#11554

Signed-off-by: Andrew Thornton <art27@cantab.net>
@guillep2k guillep2k mentioned this issue May 26, 2020
Merged
zeripath added a commit that referenced this issue May 27, 2020
@guillep2k @zeripath
When must change password only show Signout (#11600) (#11637)
600bb54 
When "Must Change Password" simplify the navbar header to only show the
signout button as all other links will redirect back. This prevents the
notifications icon from showing preventing initialization of the
event-source and hence preventing redirect_to being set, however in
addition do not set the redirect_to cookie if we are looking at the
/user/events page.

Fix #11554

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@zeripath
When must change password only show Signout (go-gitea#11600)
18c335f 
When "Must Change Password" simplify the navbar header to only show the
signout button as all other links will redirect back. This prevents the
notifications icon from showing preventing initialization of the
event-source and hence preventing redirect_to being set, however in
addition do not set the redirect_to cookie if we are looking at the
/user/events page.

Fix go-gitea#11554

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

When must change password only show signout button in header zeripath/gitea
2 participants
@zeripath @JaneYork