Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrations: NewGitlabDownloader() will ignore baseUrl when using access token #11851

Closed
gernoteger opened this issue Jun 11, 2020 · 0 comments · Fixed by #11852
Closed

migrations: NewGitlabDownloader() will ignore baseUrl when using access token #11851

gernoteger opened this issue Jun 11, 2020 · 0 comments · Fixed by #11852

Comments

@gernoteger
Copy link
Contributor

When using the migrations from go

  • Gitea version (or commit ref): master 4a4977a

Description

when creating a new GitlabDownloader with an access token instead of user/password, the provided baseUrl will be ignored.
gernoteger added a commit to gernoteger/gitea that referenced this issue Jun 11, 2020
@gernoteger
fixing go-gitea#11851: using baseUrl with access token
fa2060e
@gernoteger gernoteger mentioned this issue Jun 11, 2020
Merged
zeripath added a commit to gernoteger/gitea that referenced this issue Jun 11, 2020
@zeripath
Merge branch 'master' into fix-go-gitea#11851
867232e
zeripath pushed a commit that referenced this issue Jun 11, 2020
@gernoteger
Set the base url when migrating from Gitlab using access token or use…
a3fe9d8 
…rname without password (#11852)

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix #11851
zeripath pushed a commit to zeripath/gitea that referenced this issue Jul 1, 2020
@gernoteger @zeripath
Set the base url when migrating from Gitlab using access token or use…
43d7d7e 
…rname without password (go-gitea#11852)

Backport go-gitea#11852

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix go-gitea#11851
@zeripath zeripath mentioned this issue Jul 1, 2020
Merged
lunny added a commit that referenced this issue Jul 2, 2020
@zeripath @gernoteger @lunny
Set the base url when migrating from Gitlab using access token or use…
d737eaa 
…rname without password (#11852) (#12104)

Backport #11852

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix #11851

Co-authored-by: Gernot Eger <gernot.eger@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@gernoteger
Set the base url when migrating from Gitlab using access token or use…
789b642 
…rname without password (go-gitea#11852)

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix go-gitea#11851
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gernoteger