Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add login source #16541

Closed
1 of 2 tasks
zeripath opened this issue Jul 24, 2021 · 0 comments · Fixed by #16543
Closed
1 of 2 tasks

Can't add login source #16541

zeripath opened this issue Jul 24, 2021 · 0 comments · Fixed by #16543
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug

Comments

@zeripath
Copy link
Contributor

  • Gitea version (or commit ref): v1.16.0-dev-44-gd717c692f
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No: requires admin access
  • Log gist:
    <None relevant>

Description

#16199 unfortunately has broken the add login source page.

The bug appears to relate to String() method on the types - meaning that UI isn't getting the integer to run its test on.

@zeripath zeripath added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Jul 24, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Jul 24, 2021
There is a regression in go-gitea#16199 whereby the add authentication page
fails to react to the change in selected type.

This is due to the String() method on the LoginSourceType which is ameliorated
with an Int() function being added.

Following on from this there are a few other related bugs.

Fix go-gitea#16541

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Jul 25, 2021
* Fix add authentication page

There is a regression in #16199 whereby the add authentication page
fails to react to the change in selected type.

This is due to the String() method on the LoginSourceType which is ameliorated
with an Int() function being added.

Following on from this there are a few other related bugs.

Fix #16541

Signed-off-by: Andrew Thornton <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
* Fix add authentication page

There is a regression in go-gitea#16199 whereby the add authentication page
fails to react to the change in selected type.

This is due to the String() method on the LoginSourceType which is ameliorated
with an Int() function being added.

Following on from this there are a few other related bugs.

Fix go-gitea#16541

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant