Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Add download button to file view #17286

Closed
6543 opened this issue Oct 10, 2021 · 8 comments · Fixed by #17640
Closed

[UI] Add download button to file view #17286

6543 opened this issue Oct 10, 2021 · 8 comments · Fixed by #17640
Labels
hacktoberfest topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.16.0

Comments

@6543
Copy link
Member

6543 commented Oct 10, 2021

Add a download button on file view to make it easy to download files for people not familiar with gitea/github/...

ref: https://youtu.be/mvk5tVMZQ_U?t=3198
@6543 6543 added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI hacktoberfest labels Oct 10, 2021
@georgioupanayiotis
Copy link

Hello @6543 can I take this issue?

@6543
Copy link
Member Author

6543 commented Oct 10, 2021

@georgioupanayiotis It's yours

@6543 6543 added this to the 1.16.0 milestone Oct 10, 2021
@6543
Copy link
Member Author

6543 commented Oct 12, 2021

@georgioupanayiotis if you need help dont be afraid to as on our discord server :)

@axifive
Copy link
Member

axifive commented Oct 12, 2021

rename Raw -> Download? 😄

@a1012112796
Copy link
Member

git-master can provide download button for github, but not support it for gitea. maybe we can do it.

image

@Rotekoppen
Copy link

Quick inspect element edit illustration of a possible placement/design the button could have

Skjermdump fra 2021-10-14 17-45-55

Skjermdump fra 2021-10-14 17-48-55

@6543
Copy link
Member Author

6543 commented Oct 14, 2021

instead of a "Download" button what about a icon:
Bildschirmfoto zu 2021-10-14 18-15-08
?

@Theta-Dev
Copy link
Contributor

Yes, that's a good idea. Stick the download icon right next to the edit and delete buttons, similar to how it's done in GitLab.

image

Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 14, 2021
Add download button for file viewer
5a12e75 
- Resolves go-gitea#17286
- Use the `download` attribute such that the browser will natively
initate a download dialog for the given URL.
@Gusted Gusted mentioned this issue Nov 14, 2021
Merged
lunny pushed a commit that referenced this issue Nov 15, 2021
@6543 @techknowlogick
Add download button for file viewer (#17640)
562785e 
- Resolves #17286
- Use the `download` attribute such that the browser will natively
initate a download dialog for the given URL.

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@6543 @techknowlogick
Add download button for file viewer (go-gitea#17640)
49ab8c6 
- Resolves go-gitea#17286
- Use the `download` attribute such that the browser will natively
initate a download dialog for the given URL.

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
hacktoberfest topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Add download button for file viewer Gusted/gitea
6 participants
@axifive @georgioupanayiotis @Theta-Dev @6543 @a1012112796 @Rotekoppen