Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Statuses popup to large to open with 21 statuses #17443

Closed
ChristopherHX opened this issue Oct 26, 2021 · 3 comments · Fixed by #17447 or #17466
Closed

Commit Statuses popup to large to open with 21 statuses #17443

ChristopherHX opened this issue Oct 26, 2021 · 3 comments · Fixed by #17447 or #17466
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@ChristopherHX
Copy link
Contributor

Gitea Version

1.15.2

Operating System

Windows 11

Browser Version

Microsoft Edge Version 95.0.1020.30 (64-bit)

Can you reproduce the bug on the Gitea demo site?

Yes

Description

The commit statuses popup doesn't fit in the browsers viewport if you have 21 status checks or more attached to one commit.
My system has a resolution of 1920x1080. Viewing gitea with 50% of normal size allows the popup to open correctly.

If a commit only has a view status checks it works correctly.

How to repoduce

I expected pressing the green checkmark would always open the statuses popup.

I would try to contribute a fix for this issue in the following months. I haven't found any similar issues for gitea.
I'm experimenting with github actions for gitea, which generates a lot of statuses for jobs #13539 (comment)

Screenshots

Pressing the green check mark, causes errors in my dev console: Popup: Popup does not fit within the boundaries of the viewport and the popup refuses to open.
image

Expected result with a scale of 50%, after clicking the green checkmark
image

@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Oct 27, 2021
@wxiaoguang

This comment has been minimized.

zeripath pushed a commit that referenced this issue Oct 28, 2021
Close #17443

Maybe we do not need to backport this PR, the bug doesn't break daily usage.

After the fix, the commit statuses popup can show a lot of lines with scroll bars:

![image](https://user-images.githubusercontent.com/2114189/139026160-f01b484c-6207-494a-a190-a6dd184ceb2b.png)
@lunny lunny added this to the 1.15.6 milestone Oct 28, 2021
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 28, 2021

Fixed in the main branch. Will backport.

Screenshots for different window size:

image

image

image

@ChristopherHX
Copy link
Contributor Author

@wxiaoguang
Thank you very much for your very fast fix. The popup is now also working on my smartphone. Good work.

Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
Close go-gitea#17443

Maybe we do not need to backport this PR, the bug doesn't break daily usage.

After the fix, the commit statuses popup can show a lot of lines with scroll bars:

![image](https://user-images.githubusercontent.com/2114189/139026160-f01b484c-6207-494a-a190-a6dd184ceb2b.png)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
3 participants