Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #18239

Closed
6543 opened this issue Jan 11, 2022 · 4 comments
Closed

Migrate from gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #18239

6543 opened this issue Jan 11, 2022 · 4 comments
Assignees
@6543
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Milestone
1.17.0

Comments

@6543
Copy link
Member

6543 commented Jan 11, 2022

No description provided.

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. dependencies labels Jan 11, 2022
@6543 6543 added this to the 1.17.0 milestone Jan 11, 2022
@6543 6543 self-assigned this Jan 11, 2022
@6543
Copy link
Member Author

6543 commented Jan 13, 2022 •
edited
Loading

blocked by https://github.com/yuin/goldmark-meta who return v2 parsed data:

gitea/modules/markup/markdown/goldmark.go

Lines 42 to 52 in f635d60

metaData := meta.GetItems(pc)
firstChild := node.FirstChild()
createTOC := false
var toc = []Header{}
rc := &RenderConfig{
Meta: "table",
Icon: "table",
Lang: "",
}
if metaData != nil {
rc.ToRenderConfig(metaData)

WIP: https://github.com/yuin/goldmark-meta/compare/master...6543-forks:yaml.v3?expand=1

@6543 6543 mentioned this issue Jan 13, 2022
Closed
@6543
Copy link
Member Author

6543 commented Apr 30, 2022

not possible for now see yuin/goldmark-meta#6

@6543 6543 closed this as completed Apr 30, 2022
@6543 6543 reopened this Jun 18, 2022
@6543
Copy link
Member Author

6543 commented Jun 18, 2022 •
edited
Loading

looking if GHSA-hp87-p4gw-j4gq (CVE-2022-28948) does affect v2 ...

@6543
Copy link
Member Author

6543 commented Jun 18, 2022

go-yaml/yaml#666 (comment)

@6543 6543 closed this as completed Jun 18, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@6543 6543

Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
1 participant
@6543