migrate to yaml.v3 #6
Conversation
| return node.Value | ||
| } | ||
|
|
||
| return fmt.Sprintf("<do not support yaml node kind '%v'>", node.Kind) |
There was a problem hiding this comment.
I'd like to change api fo this func so we can pass error obj upstream ... - just not done because like to get some ACK to change api of this lib more drastically
There was a problem hiding this comment.
@yuin can you ACK Y/N/need-more-discussion?
|
Sorry for late reply. This PR seems containing API breaking changes. So it should be v2. |
|
@yuin yes thats why I'm asking if i should propose changes as a whole for a v2 Do you have some channel to chat about it? |
|
Sorry, I'm VERY poor at English. I can not chat in English. And I have less motivation about version up of go-yaml. We do not use complicate functions about YAML. And goldmark users that use this extension most unlikely to write complex YAML in a metadata section. What is your motivation about version up? |
|
well is probably the best for now - if you plan a new version for goldmark-meta please reopen this and ping me :) @yuin |
this is a breaking change and we should think of a major version bump ...