Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing PR Comment Resolved State Disables Further Changes #18315

Closed
delvh opened this issue Jan 17, 2022 · 2 comments · Fixed by #18323
Closed

Changing PR Comment Resolved State Disables Further Changes #18315

delvh opened this issue Jan 17, 2022 · 2 comments · Fixed by #18323
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.16.0

Comments

@delvh
Copy link
Member

delvh commented Jan 17, 2022

Gitea Version

1.16.0+dev-863-g076cead40

Operating System

Kubuntu 20.04

Browser Version

Firefox 96.0

Can you reproduce the bug on the Gitea demo site?

Yes

Description

When I change a PR comment in terms of it being resolved, I cannot (un-)resolve it any further without reloading the page.
What I mean by that:
Resolve a comment, and then try to unresolve it. It won't work.
The same is true when unresolving a resolved comment and then trying to re-resolve it.

The corresponding button seems to now be nothing more than a glorified label, especially regarding that the button text will be selected when pressing it.

Screenshots

Not possible as simply nothing happens.
@delvh delvh added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 17, 2022
@delvh delvh added this to the 1.16.0 milestone Jan 17, 2022
@wxiaoguang
Copy link
Contributor

Good catch, I am working on it, it will be fixed soon.

@wxiaoguang wxiaoguang added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Jan 18, 2022
@wxiaoguang wxiaoguang mentioned this issue Jan 18, 2022
Merged
@wxiaoguang wxiaoguang linked a pull request Jan 18, 2022 that will close this issue
Fix PR comments UI #18323
Merged
@wxiaoguang
Copy link
Contributor

Fixed in #18323

wxiaoguang added a commit that referenced this issue Jan 18, 2022
@wxiaoguang
Fix PR comments UI (#18323)
84f8ef3 
Closes:
* Review comment cannot be edited #17768
* Changing PR Comment Resolved State Disables Further Changes #18315
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@wxiaoguang
Fix PR comments UI (go-gitea#18323)
78e918b 
Closes:
* Review comment cannot be edited go-gitea#17768
* Changing PR Comment Resolved State Disables Further Changes go-gitea#18315
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Fix PR comments UI wxiaoguang/gitea
2 participants
@wxiaoguang @delvh