Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea 1.16.0 crash when click on repo link #18471

Closed
muzsij opened this issue Jan 30, 2022 · 0 comments · Fixed by #18472
Closed

Gitea 1.16.0 crash when click on repo link #18471

muzsij opened this issue Jan 30, 2022 · 0 comments · Fixed by #18472
Labels
Milestone

Comments

@muzsij
Copy link

muzsij commented Jan 30, 2022

Gitea Version

1.16.0

Git Version

2.30.2

Operating System

docker in ubuntu focal

How are you running Gitea?

I run gitea and drone with docker-compose.
image: gitea/gitea:latest

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/hypernics/12552cd6b64454fd9d5bedbe61571b91

Description

After upgrading to 1.16.0 with docker-compose, when I click on a repo link some of them crash the gitea server.
It worked with 1.15.x
I just clicked all of my project repo links and as I see all my Laravel project crash the server, python and javascript projects are working.

Screenshots

No response

Gusted pushed a commit to Gusted/gitea that referenced this issue Jan 30, 2022
- Don't panic when the full regex isn't matched and allow the usage of a
shorter sha1 being used.
- Resolves go-gitea#18471
@zeripath zeripath added this to the 1.16.1 milestone Jan 30, 2022
lafriks pushed a commit that referenced this issue Jan 30, 2022
…are URLs (#18472)

* Don't panic & allow shorter sha1

- Don't panic when the full regex isn't matched and allow the usage of a
shorter sha1 being used.
- Resolves #18471

* Update modules/markup/html.go

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zeripath added a commit to zeripath/gitea that referenced this issue Jan 31, 2022
Unfortunately go-gitea#18472 only fixed part of the ways a nil pointer can occur in the
compare url. We also need to ensure that the match array has all the matches present.

Fix go-gitea#18471
Related go-gitea#18472

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Jan 31, 2022
Backport go-gitea#18490

Unfortunately go-gitea#18472 only fixed part of the ways a nil pointer can occur in the
compare url. We also need to ensure that the match array has all the matches present.

Fix go-gitea#18471
Related go-gitea#18472

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
…are URLs (go-gitea#18472)

* Don't panic & allow shorter sha1

- Don't panic when the full regex isn't matched and allow the usage of a
shorter sha1 being used.
- Resolves go-gitea#18471

* Update modules/markup/html.go

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants