You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, PR #19732 doesn't ensure all unit tests call git.Init correctly.
// at the moment, we just use a temp HomeDir to prevent from conflicting with user's git config// in future, the git module should be initialized first before use.HomeDir=filepath.Join(os.TempDir(), "/gitea-temp-home")
log.Warn("Git's HomeDir is empty, the git module is not initialized correctly, using a temp HomeDir (%s) temporarily", HomeDir)
This issue is here to remind that these unit tests should be fixed after #19732 gets merged.
And one more thing, since Gitea 1.17 has dropped Git<2.0 (#19577), some code might be cleaned, too.
The text was updated successfully, but these errors were encountered:
wxiaoguang
changed the title
Fix all unit tests without git.Init after #19732 merged
Fix all unit tests without git.Init after #19732 merged, clean code for git < 2.0
Jun 9, 2022
wxiaoguang
changed the title
Fix all unit tests without git.Init after #19732 merged, clean code for git < 2.0
Fix all unit tests without git.Init after #19732 merged, clean code for git < 2.0 after #19577
Jun 9, 2022
At the moment, PR #19732 doesn't ensure all unit tests call git.Init correctly.
This issue is here to remind that these unit tests should be fixed after #19732 gets merged.
And one more thing, since Gitea 1.17 has dropped Git<2.0 (#19577), some code might be cleaned, too.
The text was updated successfully, but these errors were encountered: