-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy git code (ver < 2.0), fine tune markup tests #19930
Conversation
8956d0b
to
d556a67
Compare
d556a67
to
e8fad37
Compare
9404470
to
a148f34
Compare
a148f34
to
b32101f
Compare
This PR has done what it could do.
|
This comment was marked as outdated.
This comment was marked as outdated.
Hmm... I remember somewhere you commented about CheckLFSVersion causing problems. I wonder if It could just be folded into the Init function? |
I have tried but got no success at the moment. Since 1.17 is going to be released, I think the big refactoring could be postponed to next milestone, otherwise there will be a lot of code changed, which may affect the 1.17 milestone.
Agree it should be refactored. I was thinking about postponing it to next milestone (reason as above). How do you think? I am fine to either plan. |
Refactor CheckAttributeReader to make a *git.Repository version
Merged, thank you very much. |
Codecov Report
@@ Coverage Diff @@
## main #19930 +/- ##
==========================================
- Coverage 47.29% 46.91% -0.38%
==========================================
Files 966 967 +1
Lines 134117 134087 -30
==========================================
- Hits 63424 62909 -515
- Misses 62977 63472 +495
+ Partials 7716 7706 -10
Continue to review full report at Codecov.
|
Do we document the min git version somewhere? |
make L-G-T-M work. |
…19930) * clean git support for ver < 2.0 * fine tune tests for markup (which requires git module) * remove unnecessary comments * try to fix tests * try test again * use const for GitVersionRequired instead of var * try to fix integration test * Refactor CheckAttributeReader to make a *git.Repository version * update document for commit signing with Gitea's internal gitconfig * update document for commit signing with Gitea's internal gitconfig Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…19930) * clean git support for ver < 2.0 * fine tune tests for markup (which requires git module) * remove unnecessary comments * try to fix tests * try test again * use const for GitVersionRequired instead of var * try to fix integration test * Refactor CheckAttributeReader to make a *git.Repository version * update document for commit signing with Gitea's internal gitconfig * update document for commit signing with Gitea's internal gitconfig Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Follows #19732 #19577
Close #19874
Major changes:
setup(including git.Init)
is called beforegit.NewCommand
git.InitXxx
git.InitXxx
isn't called, then the calls togit.NewCommand
will result in error.markup
modulegit.InitXxx
Files changed: Diff with whitespace-ignored