Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create links to Ghost users #20559

Closed
delvh opened this issue Jul 30, 2022 · 0 comments · Fixed by #20577
Closed

Do not create links to Ghost users #20559

delvh opened this issue Jul 30, 2022 · 0 comments · Fixed by #20577
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@delvh
Copy link
Member

delvh commented Jul 30, 2022

Clicking on links to the user 'Ghost' also leads to a 404.

This sounds like a bug of its own. Normally, ghost users should not have any links. Where exactly do you see these links?

In the timeline of an issue where the user had added or removed Labels, there are items such as "Ghost added the label 'in-progress'" where clicking Ghost navigates to [host]/Ghost which 404s

Originally posted by @sogono in #20494 (comment)
@delvh delvh added the type/bug label Jul 30, 2022
@noerw noerw added the topic/ui Change the appearance of the Gitea UI label Jul 31, 2022
zeripath added a commit to zeripath/gitea that referenced this issue Jul 31, 2022
@zeripath
Do not add links to Posters or Assignees with ID < 0
8281ea2 
Fix go-gitea#20559

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jul 31, 2022
Merged
zeripath added a commit that referenced this issue Sep 3, 2022
@zeripath
Do not add links to Posters or Assignees with ID < 0 (#20577)
de7b87f 
There are several places in templates/repo/issue/view_content/comments.tmpl where links are made to Posters or Assignees who are Ghosts or have IDs <0.

Fix #20559

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Sep 3, 2022
@zeripath
Do not add links to Posters or Assignees with ID < 0 (go-gitea#20577)
9f20b44 
Backport go-gitea#20577

There are several places in templates/repo/issue/view_content/comments.tmpl where links are made to Posters or Assignees who are Ghosts or have IDs <0.

Fix go-gitea#20559

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Sep 3, 2022
Merged
lunny pushed a commit that referenced this issue Sep 3, 2022
@zeripath
Do not add links to Posters or Assignees with ID < 0 (#20577) (#21037)
2f0a1eb 
Backport #20577

There are several places in templates/repo/issue/view_content/comments.tmpl where links are made to Posters or Assignees who are Ghosts or have IDs <0.

Fix #20559

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not add links to Posters or Assignees with ID < 0 zeripath/gitea
2 participants
@noerw @delvh