Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrored commits omitting leading zero from GPG Key ID #20876

Closed
calvinbui opened this issue Aug 20, 2022 · 0 comments · Fixed by #20878
Closed

Mirrored commits omitting leading zero from GPG Key ID #20876

calvinbui opened this issue Aug 20, 2022 · 0 comments · Fixed by #20878
Labels

Comments

@calvinbui
Copy link

Description

I am mirroring my public GitHub repo into Gitea.

Commits mirrored into Gitea are missing the leading zero from the GPG Key ID, resulting in a No known key found for this signature in database message.

Gitea Version

1.17.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

image

image

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

PostgreSQL

@calvinbui calvinbui changed the title Mirrored commits to omitting leading zero from GPG Key ID Mirrored commits omitting leading zero from GPG Key ID Aug 20, 2022
zeripath added a commit to zeripath/gitea that referenced this issue Aug 20, 2022
The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This
is a somewhat confusing thing for most users who expect these to have preceding zeroes.

This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding
zeroes from KeyIDs inputted on the API.

Fix go-gitea#20876

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Aug 21, 2022
Backport go-gitea#20878

The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This
is a somewhat confusing thing for most users who expect these to have preceding zeroes.

This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding
zeroes from KeyIDs inputted on the API.

Fix go-gitea#20876

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Aug 22, 2022
Backport #20878

The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This
is a somewhat confusing thing for most users who expect these to have preceding zeroes.

This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding
zeroes from KeyIDs inputted on the API.

Fix #20876

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant