DeleteIssue API fails with 500 on pull requests

[earl-warren]

Description

Calling https://try.gitea.io/api/swagger#/issue/issueDelete on a pull request fails with the following error on v1.18.0+dev-317-g36dfe544f

The pull request is however successfully deleted.

2022/08/23 06:25:33 [630472dd-81] router: failed    DELETE /api/v1/repos/user5577006791947779410/projectname/issues/1 for 172.17.0.1:58026, panic in 20.9ms @ repo/issue.go:846(repo.DeleteIssue), err=runtime error: invalid memory address or nil pointer dereference
2022/08/23 06:25:33 ...common/middleware.go:71:1() [E] [630472dd-81] PANIC: runtime error: invalid memory address or nil pointer dereference
	/usr/local/go/src/runtime/panic.go:260 (0x459595)
	/usr/local/go/src/runtime/signal_unix.go:835 (0x459565)
	/go/src/code.gitea.io/gitea/modules/git/repo_commit_nogogit.go:59 (0xe4ad59)
	/go/src/code.gitea.io/gitea/services/issue/issue.go:152 (0x1be1758)
	/go/src/code.gitea.io/gitea/routers/api/v1/repo/issue.go:884 (0x2131fb3)
	/go/src/code.gitea.io/gitea/modules/web/wrap_convert.go:63 (0x1fa9913)
	/go/src/code.gitea.io/gitea/modules/web/wrap.go:41 (0x1fa7fe4)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1bb5355)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/modules/web/wrap.go:98 (0x1fa8a6c)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/modules/web/wrap.go:98 (0x1fa8a6c)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/modules/context/api.go:277 (0x1bbcb51)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/routers/api/v1/api.go:1190 (0x2180493)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1bb3114)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x1bb4b1b)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1bb5355)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/routers/common/middleware.go:79 (0x2068562)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:123 (0x1fa3cf3)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x2065df8)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x2062816)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/src/code.gitea.io/gitea/routers/common/middleware.go:32 (0x20683b1)
	/usr/local/go/src/net/http/server.go:2109 (0x94c30e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x1bb30cf)
	/go/src/code.gitea.io/gitea/modules/web/route.go:200 (0x1fa740d)
	/usr/local/go/src/net/http/server.go:2947 (0x94f70b)
	/usr/local/go/src/net/http/server.go:1991 (0x94ade6)
	/usr/local/go/src/runtime/asm_amd64.s:1594 (0x477280)

Gitea Version

v1.18.0+dev-317-g36dfe544f

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

a

Screenshots

a

Git Version

a

Operating System

a

How are you running Gitea?

a

Database

No response