Panic in RestoreBranchPost if click restore branch muiltple time in one branch #21930
Labels
Comments
ghost
added
the
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Nov 25, 2022
If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix go-gitea#21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this issue
Nov 25, 2022
…21940) If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix #21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Nov 25, 2022
…o-gitea#21940) Backport go-gitea#21940 If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix go-gitea#21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
pushed a commit
that referenced
this issue
Nov 25, 2022
…21940) (#21944) Backport #21940 If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix #21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
We know that deleted branches will retain a history for a period of time if garbage collection is not run.
If the branch has been restored, executing restore again will cause panic.
Gitea Version
1.19.0+dev
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
https://gist.github.com/xin-u/b7aa208c095c833f4a0e09adbce4decb
Screenshots
No response
Git Version
main
Operating System
No response
How are you running Gitea?
build from source
Database
SQLite
The text was updated successfully, but these errors were encountered: