Can't execute gitea.exe on Windows in cmd.exe

[crackedmind]

Description

>gitea-1.18.0-rc1-windows-4.0-amd64.exe --help
2022/12/07 23:15:28 ...s/setting/setting.go:516:1() [F] Failed to get app path: exec: "gitea.exe": cannot run executable found relative to current directory

From powershell it starts normally.

And it' working as expected in cmd.exe for 1.17.3

>gitea-1.17.3-windows-4.0-amd64.exe --help
NAME:
   Gitea - A painless self-hosted Git service

Gitea Version

1.18-rc1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows 11

How are you running Gitea?

Official gitea-1.18.0-rc1-windows-4.0-amd64.exe

Database

None

[eeyrjmr]

Duplicate of #21943

NOTE: it might have been premature to close the other issue as it just captures a "workaround" not the change in behaviour (or regression...)

[KazzmanK]

but it still runs as windows service as previously.

[zeripath]

I wonder if this would fix this?

diff --git a/modules/setting/setting.go b/modules/setting/setting.go
index f0d7f0292..6d99ffa0f 100644
--- a/modules/setting/setting.go
+++ b/modules/setting/setting.go
@@ -6,6 +6,7 @@ package setting
 
 import (
 	"encoding/base64"
+	"errors"
 	"fmt"
 	"math"
 	"net"
@@ -465,6 +466,13 @@ func getAppPath() (string, error) {
 		appPath, err = exec.LookPath(os.Args[0])
 	}
 
+	if err != nil {
+		if !errors.Is(err, exec.ErrDot) {
+			return "", err
+		}
+		appPath, err = os.Getwd()
+		appPath = filepath.Join(appPath, os.Args[0])
+	}
 	if err != nil {
 		return "", err
 	}

[zeripath]

The trouble is I can't test this because I don't run windows.

[eeyrjmr]

The trouble is I can't test this because I don't run windows.

If I can figure out how to cross compile in Gentoo , I can test

[zeripath]

make release-windows

[zeripath]

ok so it looks like my patch does work!

Right I'll try to clean it up a bit and push it up as a fix.