Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord hooks can't be delivered since today #22391

Closed
crackedmind opened this issue Jan 10, 2023 · 2 comments · Fixed by #22393
Closed

Discord hooks can't be delivered since today #22391

crackedmind opened this issue Jan 10, 2023 · 2 comments · Fixed by #22393
Labels
Milestone

Comments

@crackedmind
Copy link

crackedmind commented Jan 10, 2023

Description

With empty icon url discord answer this

{"avatar_url": ["Scheme "" is not supported. Scheme must be one of ('http', 'https')."]}

Maybe set this field to favicon if icon url is empty? Manual update all hooks it's not i want to do.

Gitea Version

1.17.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.service

Database

SQLite

@jolheiser
Copy link
Member

Interesting, not sure if this is new on the Discord API side or what.
I will look at implementing a fix, considering we have that field marked as optional.

techknowlogick pushed a commit that referenced this issue Jan 10, 2023
Fixes #22391

This field is optional for Discord, however when it exists in the
payload it is now validated.
Omitting it entirely just makes Discord use the default for that
webhook, which is set on the Discord side.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser added a commit to jolheiser/gitea that referenced this issue Jan 10, 2023
Fixes go-gitea#22391

This field is optional for Discord, however when it exists in the
payload it is now validated.
Omitting it entirely just makes Discord use the default for that
webhook, which is set on the Discord side.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser added a commit to jolheiser/gitea that referenced this issue Jan 10, 2023
Fixes go-gitea#22391

This field is optional for Discord, however when it exists in the
payload it is now validated.
Omitting it entirely just makes Discord use the default for that
webhook, which is set on the Discord side.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Copy link
Member

jolheiser commented Jan 10, 2023

This fix should land in 1.18.1 when we release it. 🙂

@lunny lunny added this to the 1.18.1 milestone Jan 11, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants