Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close_at always null for API: repos/{owner}/{repo}/pulls API #22480

Closed
dfelinto opened this issue Jan 17, 2023 · 1 comment · Fixed by #22482
Closed

close_at always null for API: repos/{owner}/{repo}/pulls API #22480

dfelinto opened this issue Jan 17, 2023 · 1 comment · Fixed by #22482
Assignees
@yardenshoham
Labels
type/bug

Comments

@dfelinto
Copy link
Contributor

Description

The field "close_at" is always NULL for pull requests API queries.

You can see the error here:
https://try.gitea.io/api/v1/repos/dfelinto/blender/pulls

It doesn't matter if the pull request was closed manually (id=13601) or merged (id=13600).

Gitea Version

1.19.0+dev-310-g1aba53db6

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I can reproduce this both with try.gitea.io and a local instance running 1.18.0 from the binary.

Database

SQLite
@yardenshoham yardenshoham self-assigned this Jan 17, 2023
@dfelinto
Copy link
Contributor Author

I just realized that if I query for the issues of type pulls instead I get the closed_at:
https://try.gitea.io/api/v1/repos/dfelinto/blender/issues?state=all&type=pulls

I will be using the issues query instead. It also has a better cursor/pagination with the 'since' field. So this bug doesn't bother me anymore.

This was referenced Jan 17, 2023
Merged
Merged
zeripath pushed a commit that referenced this issue Jan 17, 2023
@yardenshoham
Fix pull request API field closed_at always being null (#22482) (#…
45bdeac 
…22483)

Backport #22482

Fix #22480
zeripath pushed a commit that referenced this issue Jan 17, 2023
@yardenshoham
Fix pull request API field closed_at always being null (#22482)
e763fab 
Fix #22480
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yardenshoham yardenshoham

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pull request API field closed_at always being null yardenshoham/gitea
2 participants
@dfelinto @yardenshoham