Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long full name/username causes repo view to overflow #22866

Closed
Maks1mS opened this issue Feb 11, 2023 · 3 comments · Fixed by #23030
Closed

Long full name/username causes repo view to overflow #22866

Maks1mS opened this issue Feb 11, 2023 · 3 comments · Fixed by #23030
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.18.6

Comments

@Maks1mS
Copy link
Contributor

Maks1mS commented Feb 11, 2023

Description

Similar as #22360, but with full name/username.

I can't reproduce on the Gitea demo site because it returns "Bad Gateway".

Screenshots

image

Gitea Version

1.18.3

Can you reproduce the bug on the Gitea demo site?

No

Operating System

No response

Browser Version

Chrome 109.0.5414.119
@Maks1mS Maks1mS added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 11, 2023
@VladBrok
Copy link

I have this bug too

@wxiaoguang
Copy link
Contributor

The same on try.gitea.io (main dev branch)

image

@HesterG HesterG mentioned this issue Feb 21, 2023
Merged
@lunny lunny added this to the 1.18.5 milestone Feb 21, 2023
@delvh delvh modified the milestones: 1.18.5, 1.18.6 Feb 22, 2023
jolheiser pushed a commit that referenced this issue Feb 23, 2023
@HesterG
Add wrapper to author to avoid long name ui problem (#23030)
8ed6096 
This PR is a possible solution for issue #22866. Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now.
@yardenshoham yardenshoham mentioned this issue Feb 23, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 23, 2023
@HesterG @yardenshoham
Add wrapper to author to avoid long name ui problem (go-gitea#23030)
58544db 
This PR is a possible solution for issue go-gitea#22866. Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now.
lunny added a commit that referenced this issue Feb 24, 2023
@yardenshoham @HesterG @lunny
Add wrapper to author to avoid long name ui problem (#23030) (#23098)
ddf6137 
Backport #23030

This PR is a possible solution for issue #22866. Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now. Which will work like below:

<img width="1183" alt="2023-02-21 11 57 53"
src="https://user-images.githubusercontent.com/17645053/220244146-3d47c512-33b6-4ed8-938e-de0a8bc26ffb.png">

<img width="417" alt="2023-02-21 11 58 43"
src="https://user-images.githubusercontent.com/17645053/220244154-1ea0476b-9d1c-473a-9917-d3216860f9a9.png">

And `title` is added to the wrapper like it did in message wrapper. So
the full author name will show on hover.

Co-authored-by: HesterG <hestergong@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@jolheiser
Copy link
Member

Should be fixed by #23030

HesterG added a commit to HesterG/gitea that referenced this issue Feb 27, 2023
@HesterG
This PR is a possible solution for issue go-gitea#22866. Main change …
2502f4e 
…is to add a

`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now.
@HesterG HesterG mentioned this issue Feb 27, 2023
Merged
lunny pushed a commit that referenced this issue Feb 27, 2023
@HesterG
Add wrapper to author to avoid long name ui problem (#23030) (#23172)
5a60e02 
Backport #23030 

This PR is a possible solution for issue #22866. Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now. Which will work like below:

<img width="1183" alt="2023-02-21 11 57 53"
src="https://user-images.githubusercontent.com/17645053/220244146-3d47c512-33b6-4ed8-938e-de0a8bc26ffb.png">

<img width="417" alt="2023-02-21 11 58 43"
src="https://user-images.githubusercontent.com/17645053/220244154-1ea0476b-9d1c-473a-9917-d3216860f9a9.png">

And `title` is added to the wrapper like it did in message wrapper. So
the full author name will show on hover.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.18.6
Development

Successfully merging a pull request may close this issue.

Add wrapper to author to avoid long name ui problem HesterG/gitea
6 participants
@lunny @wxiaoguang @Maks1mS @jolheiser @delvh @VladBrok