Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The link of org people/member page #22931

Closed
yp05327 opened this issue Feb 16, 2023 · 1 comment · Fixed by #22960
Closed

The link of org people/member page #22931

yp05327 opened this issue Feb 16, 2023 · 1 comment · Fixed by #22960
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@yp05327
Copy link
Contributor

yp05327 commented Feb 16, 2023 •
edited
Loading

Feature Description

Org people page's link is domain/org/{OrgName}/members.
Maybe domain/org/{OrgName}/people is better or just change the tab name from People to Members?

Screenshots

No response
@yp05327 yp05327 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Feb 16, 2023
@wolfogre
Copy link
Member

wolfogre commented Feb 16, 2023 •
edited by delvh
Loading

I prefer renaming People to Members, it's always Members in the code.

BTW, if somebody can help rename it, please change the icon too, it looks like buildings.

image

@lunny lunny removed the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 16, 2023
@yardenshoham yardenshoham mentioned this issue Feb 17, 2023
Merged
lunny pushed a commit that referenced this issue Feb 18, 2023
@yardenshoham @delvh
Rename "People" to "Members" in organization page and use a better ic…
feed1ff 
…on (#22960)

`member` is how it's named in the code

Closes #22931 

Before | After
--- | ---

![image](https://user-images.githubusercontent.com/20454870/219781155-69a8476e-0f04-4b70-bda5-ea6fa8ce676c.png)
|
![image](https://user-images.githubusercontent.com/20454870/219780887-61644c27-36a2-4e1f-8f98-be3911883b49.png)

---------

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: delvh <leon@kske.dev>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename "People" to "Members" in organization page and use a better icon yardenshoham/gitea
3 participants
@lunny @wolfogre @yp05327