Organization-wide projects bugs #23318

delvh · 2023-03-05T20:58:35Z

yp05327 · 2023-03-07T06:31:53Z

Thanks for your summarization.

I tried to fix some of them about one month ago
The first PR is

Add missing tabs to org projects page #22705, ~~but it seems not easy to fix it, as I found more problems in CI result:~~
Add default owner team to privated_org and limited_org in unit test #23109 (Merged)
"/api/packages/{username}/nuget" will always return http.StatusOK no matter whether doer has permission #23349
↑
I designed a new solution to avoid this CI failure

The second one is #22865, but it is too big, I'm spliting this PR into several small ones. then it will be easier to review:

yp05327 · 2023-03-10T01:36:20Z

@delvh

Org projects ignore the column color, see screenshots 1 and 2, the right column should have the color #ff0000.

I notice that we can not edit the column color in both repo and org/user projects in current main branch.
In 1.18.5, I can edit the column color in both repo projects.
It seems that the link is incorrect. I will fix this later.
Can you confirm this problem, and add to the task list?
Thanks.

↑
Fix: #23400

Maybe we need a test to avoid this again.

yp05327 · 2023-03-10T02:06:21Z

repo projects allow to set the card preview type during creation. Organization projects don't, see screenshots 5 and 6

The select box will display nothing even if one is selected.

…4043) Part of #23318 The way to fix the missing cardtype for user/org level projects in this PR is to port the cardtype related part from #22112 to org/user level projects' template and router functions. Before: <img width="1135" alt="截屏2023-04-11 13 55 49" src="https://user-images.githubusercontent.com/17645053/231069068-ba897129-ae90-4aa0-9b0f-468bf5c65375.png"> <img width="1131" alt="截屏2023-04-11 13 55 59" src="https://user-images.githubusercontent.com/17645053/231069084-279f6681-5a10-42da-b5a8-2b0ba47c7078.png"> After: Create <img width="835" alt="截屏2023-04-11 13 27 16" src="https://user-images.githubusercontent.com/17645053/231064445-0d6e12bd-5725-48db-a102-80e7472757c2.png"> Edit <img width="852" alt="截屏2023-04-11 13 27 05" src="https://user-images.githubusercontent.com/17645053/231064503-c70525cd-1038-43ec-8d93-8b8d95d183d4.png"> View <img width="1329" alt="截屏2023-04-11 13 26 56" src="https://user-images.githubusercontent.com/17645053/231064529-26023c85-698b-4b2e-af02-45f9820c77ec.png"> Co-authored-by: Giteabot <teabot@gitea.io>

…4043) (#24066) Backport #24043 Part of #23318 The way to fix the missing cardtype for user/org level projects in this PR is to port the cardtype related part from #22112 to org/user level projects' template and router functions. Before: <img width="1135" alt="截屏2023-04-11 13 55 49" src="https://user-images.githubusercontent.com/17645053/231069068-ba897129-ae90-4aa0-9b0f-468bf5c65375.png"> <img width="1131" alt="截屏2023-04-11 13 55 59" src="https://user-images.githubusercontent.com/17645053/231069084-279f6681-5a10-42da-b5a8-2b0ba47c7078.png"> After: Create <img width="835" alt="截屏2023-04-11 13 27 16" src="https://user-images.githubusercontent.com/17645053/231064445-0d6e12bd-5725-48db-a102-80e7472757c2.png"> Edit <img width="852" alt="截屏2023-04-11 13 27 05" src="https://user-images.githubusercontent.com/17645053/231064503-c70525cd-1038-43ec-8d93-8b8d95d183d4.png"> View <img width="1329" alt="截屏2023-04-11 13 26 56" src="https://user-images.githubusercontent.com/17645053/231064529-26023c85-698b-4b2e-af02-45f9820c77ec.png"> --------- Co-authored-by: silverwind <me@silverwind.io>

HesterG · 2023-04-13T03:19:03Z

Find another issue, Buttons used on "set defualt" and "delete column" are not proper, so cancel will disappear on hover. And this occurs on both repo and org level projects:

default.mov

IMO It is a good idea to use delete_modal_actions.tmpl here both to fix this issue and keep ui consistency as suggested by TODO here
I will open a PR to solve this.

yp05327 · 2023-04-13T03:50:15Z

Maybe this problem is caused by css?
The button will not disappear in dark mode.

If I open devtools in chrome, the button works well in dark mode.
But if I close DevTools, the button will have no changes when mouse move across the button.

Open devtools:
mouse not on the button:

mouse on the button:

Close devtools (always same as mouse on the button):

Tested in gitea.com

HesterG · 2023-04-13T05:59:40Z

Maybe this problem is caused by css? The button will not disappear in dark mode.

If I open devtools in chrome, the button works well in dark mode. But if I close DevTools, the button will have no changes when mouse move across the button.

Open devtools: mouse not on the button: mouse on the button:

Close devtools (always same as mouse on the button): Tested in gitea.com

Yes it is caused by css, the reason why arc-green theme looks good is because the color for the text on cancel button on hover is different from gitea theme. And here it might be more suitable to use delete_modal_actions.tmpl also for consistency, like some other places with the similar modal ui:

e.g. Delete Project UI:

silverwind · 2023-04-17T15:56:26Z

Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes.

HesterG · 2023-04-18T01:00:08Z

Looks like some bug in the button colors. I'd argue the modal buttons should be full red/green, with no inner grey border, on both themes.

Do you mean like this?

default.mov

silverwind · 2023-04-19T18:55:42Z

Do you mean like this?

I envisioned with border, but your style looks even better, let's do it.

HesterG · 2023-04-20T01:03:40Z

Do you mean like this?

I envisioned with border, but your style looks even better, let's do it.

add a commit 1df04ee to do this style

@wxiaoguang

…related actions (#24097) Co-Author: @wxiaoguang This PR is to fix #23318 (comment) . The way to fix this in this PR is to use `delete_modal_actions.tmpl` here both to fix this issue and keep ui consistency (as suggested by [TODO here](https://github.com/go-gitea/gitea/blob/4299c3b7db61f8741eca0ba3d663bb65745a4acc/templates/projects/view.tmpl#L161)) And this PR also refactors `delete_modal_actions.tmpl` and its related styles, and use the template for more modal actions: 1. Added template attributes: * locale * ModalButtonStyle: "yes" (default) or "confirm" * ModalButtonCancelText * ModalButtonOkText 2. Rename `delete_modal_actions.tmpl` template to `modal_actions_confirm.tmpl` because it is not only used for action modals deletion now. 3. Refactored css related to modals into `web_src/css/modules/modal.css` and improved the styles. 4. Also use the template for PR deletion modal and remove issue dependency modal. 5. Some modals should also use the template, but not sure how to open them, so mark these modal actions by `{{/* TODO: Convert to base/modal_actions_confirm */}}` After (Also tested on arc green): Hovering on the left buttons <img width="711" alt="Screen Shot 2023-04-23 at 15 17 12" src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png"> <img width="786" alt="Screen Shot 2023-04-23 at 15 17 21" src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png"> Test for functionalities: https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

delvh · 2023-04-23T10:40:29Z

Closed accidentally.

Part of #23318.

delvh · 2023-06-28T09:36:28Z

Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to $URL/pull/$ID instead of $URL/$USER/$REPO/pull/$ID

brenthuisman · 2023-11-21T14:11:33Z

Found another one: If you click on the PR that closed an issue inside an org-wide project, you get redirected to $URL/pull/$ID instead of $URL/$USER/$REPO/pull/$ID

Just got bit by this one (during a demo of Gitea). Tracking issues on a org board or third repo board are broken.

Fixes_ #23318 (comment)

Fixes_ go-gitea#23318 (comment)

@denyskon

Backport #28806 by @denyskon Fixes_ #23318 (comment) Co-authored-by: Denys Konovalov <kontakt@denyskon.de>

Fixes_ go-gitea#23318 (comment)

Part of #23318 Add menu in repo settings to allow for repo admin to decide not just if projects are enabled or disabled per repo, but also which kind of projects (repo-level/owner-level) are enabled. If repo projects disabled, don't show the projects tab. ![grafik](https://github.com/go-gitea/gitea/assets/47871822/b9b43fb4-824b-47f9-b8e2-12004313647c) --------- Co-authored-by: delvh <dev.lh@web.de>

denyskon · 2024-03-17T14:20:10Z

Confirmed that the last remaining issues were resolved by #28805 and #28806

delvh · 2024-03-17T14:49:42Z

I think

When creating an org project, and adding a second column only the second column can be edited, the first one can't.
See screenshot 1 and 2. Happens both for repo- and org-projects

is still present.
But apart from that, yes, agreed, we slowly seem to have gotten rid of the project bugs. Finally 😌

denyskon · 2024-03-17T15:11:37Z

@delvh Why should the default column be edited? If you don't like it, create a new one and set it as default. I think it is expected behaviour.

delvh · 2024-03-17T15:13:52Z

Why do we need such a workaround for these things?

denyskon · 2024-03-17T15:45:12Z

Well maybe it's because I always considered it to be a feature, not a bug, I don't understand where the problem is, but for me the default column always was something that is there for empty projects still to be able to contain issues, and if you need more you create a new column. We can change it of course.

delvh · 2024-03-17T20:29:31Z

That's not what I mean.
What I mean is:
Why can't I rename or recolor the default board but everything else?
However, if I change the default board, I suddenly can?

denyskon · 2024-03-17T20:34:45Z

Because thats how it is!!!!!!!!!11!1!1!1

Maybe modern-day technology just educates us to accept issues as if they were intended?

Anyways, I'll check if it can be adapted easily....

denyskon · 2024-03-17T20:41:39Z

@delvh Currently, this non-adaptable board is generated dynamically when getting a project from DB which doesn't contain a board. It could theoretically be fixed by simply creating a default board when creating an empty project.

delvh · 2024-03-17T20:42:27Z

Instead of misusing this issue for it, let's move the discussion to another one.

delvh added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 5, 2023

yp05327 mentioned this issue Mar 11, 2023

Card preview mode cannot be selected in repo items #23422

Closed

This comment was marked as duplicate.

Sign in to view

6543 added the type/summary This issue aggregates a bunch of other issues label Apr 2, 2023

HesterG mentioned this issue Apr 11, 2023

Add cardtype to org/user level project on creation, edit and view #24043

Merged

HesterG mentioned this issue Apr 12, 2023

Add cardtype to org/user level project on creation, edit and view (#24043) #24066

Merged

HesterG mentioned this issue Apr 13, 2023

Refactor delete_modal_actions template and use it for project column related actions #24097

Merged

lunny closed this as completed in #24097 Apr 23, 2023

delvh reopened this Apr 23, 2023

delvh mentioned this issue Apr 24, 2023

Fix no edit/close/delete button in org repo project view page #24301

Merged

delvh pushed a commit that referenced this issue Apr 24, 2023

Fix no edit/close/delete button in org repo project view page (#24301)

9c33cbd

Part of #23318.

This was referenced Jul 18, 2023

Link to PR on project board broken #25954

Closed

Pull request link in organization project is broken #25971

Closed

LukeOwlclaw mentioned this issue Jul 27, 2023

Styling issue on project board page #26084

Open

delvh mentioned this issue Aug 1, 2023

Wrong link to PR in user/org level project causes 404 #26272

Closed

This was referenced Jan 15, 2024

Enable/disable owner and repo projects independently #28805

Merged

Fix links in issue card #28806

Merged

lafriks pushed a commit that referenced this issue Jan 15, 2024

Fix links in issue card (#28806)

d971dfb

Fixes_ #23318 (comment)

GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 15, 2024

Fix links in issue card (go-gitea#28806)

c5052dd

Fixes_ go-gitea#23318 (comment)

GiteaBot mentioned this issue Jan 15, 2024

Fix links in issue card (#28806) #28807

Merged

lunny pushed a commit that referenced this issue Jan 16, 2024

Fix links in issue card (#28806) (#28807)

be541d9

Backport #28806 by @denyskon Fixes_ #23318 (comment) Co-authored-by: Denys Konovalov <kontakt@denyskon.de>

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024

Fix links in issue card (go-gitea#28806)

dbb9fdc

Fixes_ go-gitea#23318 (comment)

henrygoodman pushed a commit to henrygoodman/gitea that referenced this issue Jan 31, 2024

Fix links in issue card (go-gitea#28806)

1eba971

Fixes_ go-gitea#23318 (comment)

silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024

Fix links in issue card (go-gitea#28806)

8f06e92

Fixes_ go-gitea#23318 (comment)

denyskon closed this as completed Mar 17, 2024

denyskon reopened this Mar 17, 2024

denyskon self-assigned this Mar 17, 2024

delvh closed this as completed Mar 17, 2024

delvh mentioned this issue Mar 17, 2024

Allow editing default project column #29873

Closed

denyskon removed their assignment Mar 17, 2024

go-gitea locked as resolved and limited conversation to collaborators Jun 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Organization-wide projects bugs #23318

Organization-wide projects bugs #23318

delvh commented Mar 5, 2023 •

edited

Loading

yp05327 commented Mar 7, 2023 •

edited

Loading

yp05327 commented Mar 10, 2023 •

edited

Loading

yp05327 commented Mar 10, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

HesterG commented Apr 13, 2023 •

edited

Loading

yp05327 commented Apr 13, 2023 •

edited

Loading

HesterG commented Apr 13, 2023 •

edited

Loading

silverwind commented Apr 17, 2023

HesterG commented Apr 18, 2023 •

edited

Loading

silverwind commented Apr 19, 2023

HesterG commented Apr 20, 2023

delvh commented Apr 23, 2023

delvh commented Jun 28, 2023

brenthuisman commented Nov 21, 2023

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

denyskon commented Mar 17, 2024 •

edited

Loading

delvh commented Mar 17, 2024

Organization-wide projects bugs #23318

Organization-wide projects bugs #23318

Comments

delvh commented Mar 5, 2023 • edited Loading

Description

Screenshots

Screenshot 1: Org project appearance

Screenshot 2: Repo project appearance

Screenshot 3: org repo projects list

Screenshot 4: Repo projects list

Screenshot 5: New org project

Screenshot 6: New repo project

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Operating System

Browser Version

yp05327 commented Mar 7, 2023 • edited Loading

yp05327 commented Mar 10, 2023 • edited Loading

yp05327 commented Mar 10, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

HesterG commented Apr 13, 2023 • edited Loading

yp05327 commented Apr 13, 2023 • edited Loading

HesterG commented Apr 13, 2023 • edited Loading

silverwind commented Apr 17, 2023

HesterG commented Apr 18, 2023 • edited Loading

silverwind commented Apr 19, 2023

HesterG commented Apr 20, 2023

delvh commented Apr 23, 2023

delvh commented Jun 28, 2023

brenthuisman commented Nov 21, 2023

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

delvh commented Mar 17, 2024

denyskon commented Mar 17, 2024

denyskon commented Mar 17, 2024 • edited Loading

delvh commented Mar 17, 2024

delvh commented Mar 5, 2023 •

edited

Loading

yp05327 commented Mar 7, 2023 •

edited

Loading

yp05327 commented Mar 10, 2023 •

edited

Loading

HesterG commented Apr 13, 2023 •

edited

Loading

yp05327 commented Apr 13, 2023 •

edited

Loading

HesterG commented Apr 13, 2023 •

edited

Loading

HesterG commented Apr 18, 2023 •

edited

Loading

denyskon commented Mar 17, 2024 •

edited

Loading