Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current page lost when deleting a branch from branch list #23411

Closed
opengerp opened this issue Mar 10, 2023 · 5 comments · Fixed by #23420
Closed

current page lost when deleting a branch from branch list #23411

opengerp opened this issue Mar 10, 2023 · 5 comments · Fixed by #23420
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@opengerp
Copy link

Description

current page lost when deleting a branch from branch list

Gitea Version

1.17.3 built with GNU Make 4.1, go1.18.7 : bindata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

On Rocky Linux Server

Database

MySQL
@yardenshoham
Copy link
Member

Please elaborate

@opengerp
Copy link
Author

  1. i click on Code
  2. i click on Branches
  3. i click on page 2 of branches list
  4. i click on basket to delete a merged branch
  5. i confirm
  6. branch i deleted but i am back on page 1

this is annoying because i must change page each time to remove old branches
thank you!

@yardenshoham
Copy link
Member

Maybe you could automate what you are trying to do with a script that calls the API. The web UI isn't very suited for your use-case

@wxiaoguang
Copy link
Contributor

Yup, some workarounds like API-call or git-client-deletion also work.

If you want to delete branches via UI ... indeed it's a UI bug, maybe it's not too difficult to fix but it needs some time for it 😂

@yardenshoham yardenshoham added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 11, 2023
@wxiaoguang wxiaoguang mentioned this issue Mar 11, 2023
Merged
@wxiaoguang
Copy link
Contributor

See: Make branches lit page operations remember current page #23420

lunny added a commit that referenced this issue Mar 14, 2023
@wxiaoguang @wolfogre @lunny
Make branches list page operations remember current page (#23420)
6ff5400 
Close #23411

Always pass "page" query parameter to backend, and make backend respect
it.

The `ctx.FormInt("limit")` is never used, so removed.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot mentioned this issue Mar 14, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 14, 2023
@wxiaoguang @wolfogre
@lunny @GiteaBot
Make branches list page operations remember current page (go-gitea#23420
faa05d6 
)

Close go-gitea#23411

Always pass "page" query parameter to backend, and make backend respect
it.

The `ctx.FormInt("limit")` is never used, so removed.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot mentioned this issue Mar 14, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 14, 2023
@wxiaoguang @wolfogre
@lunny @GiteaBot
Make branches list page operations remember current page (go-gitea#23420
b0118b4 
)

Close go-gitea#23411

Always pass "page" query parameter to backend, and make backend respect
it.

The `ctx.FormInt("limit")` is never used, so removed.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this issue Mar 14, 2023
@GiteaBot @wxiaoguang
@wolfogre @lunny
Make branches list page operations remember current page (#23420) (#2…
8536dc4 
…3460)

Backport #23420 by @wxiaoguang

Close #23411

Always pass "page" query parameter to backend, and make backend respect
it.

The `ctx.FormInt("limit")` is never used, so removed.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
KN4CK3R added a commit that referenced this issue Mar 15, 2023
@GiteaBot @wxiaoguang
@wolfogre @lunny @KN4CK3R
Make branches list page operations remember current page (#23420) (#2…
04d489d 
…3459)

Backport #23420 by @wxiaoguang

Close #23411

Always pass "page" query parameter to backend, and make backend respect
it.

The `ctx.FormInt("limit")` is never used, so removed.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make branches list page operations remember current page wxiaoguang/gitea
3 participants
@wxiaoguang @opengerp @yardenshoham