Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser warnings related to macaron_flash cookie #24062

Closed
silverwind opened this issue Apr 11, 2023 · 3 comments · Fixed by #24107
Closed

Browser warnings related to macaron_flash cookie #24062

silverwind opened this issue Apr 11, 2023 · 3 comments · Fixed by #24107
Labels
type/bug

Comments

@silverwind
Copy link
Member

silverwind commented Apr 11, 2023 •
edited
Loading

Description

I observe these during development in Firefox, I think we should somehow fix these:

image

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes
@pierre-eliep-met
Copy link

I get the same warning, and additionnaly I can't create a Pull request on my project, don't know if it is related

@wxiaoguang
Copy link
Contributor

I get the same warning, and additionnaly I can't create a Pull request on my project, don't know if it is related

100% unrelated 😁

If you see some errors or incorrect logs, please open a new issue with details.

@wxiaoguang wxiaoguang mentioned this issue Apr 13, 2023
Merged
@wxiaoguang
Copy link
Contributor

The cookie problem: the FlashMessage code keeps sending "deleting cookie" header to browsers.

Eventually .... Refactor cookie #24107 because the old cookie code doesn't look good to me and has bugs .....

6543 pushed a commit that referenced this issue Apr 13, 2023
@wxiaoguang
Refactor cookie (#24107)
5b9557a 
Close #24062

At the beginning, I just wanted to fix the warning mentioned by #24062

But, the cookie code really doesn't look good to me, so clean up them.

Complete the TODO on `SetCookie`: 

> TODO: Copied from gitea.com/macaron/macaron and should be improved
after macaron removed.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor cookie wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @pierre-eliep-met