-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer dispaly issue #24249
Comments
Maybe I changed some code and broke it ..... (not sure .... because I made many changes on this element) I guess we could remove the |
Tested in old version(release/v1.18) have no problems. |
Does this look good to you? Fix footer display #24251 |
Fix #24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1 Screenshots: <details> <img width="1440" alt="image" src="https://user-images.githubusercontent.com/2114189/233592840-d9ef7296-64eb-4e48-a598-300807a7c2f9.png"> <img width="923" alt="image" src="https://user-images.githubusercontent.com/2114189/233593015-16edc531-43c2-4ff0-b27e-ca75dbadce0c.png"> </details> --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
Fix go-gitea#24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1 Screenshots: <details> <img width="1440" alt="image" src="https://user-images.githubusercontent.com/2114189/233592840-d9ef7296-64eb-4e48-a598-300807a7c2f9.png"> <img width="923" alt="image" src="https://user-images.githubusercontent.com/2114189/233593015-16edc531-43c2-4ff0-b27e-ca75dbadce0c.png"> </details> --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
Backport #24251 Fix #24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24269/files?diff=split&w=1 Manually tested ![image](https://user-images.githubusercontent.com/2114189/233766806-18eb18ad-0c4d-44f7-b0fc-b40466c64445.png) Co-authored-by: Lauris BH <lauris@nix.lv>
@wxiaoguang Maybe the fix of this issue is related? And |
IMO it's not related. It seems that the "issue list" page width is larger than expected. So a new issue could be fine. |
Maybe it's time to find something better for dropdowns. Maybe https://github.com/github/details-menu-element, or even better, use tippy. |
It's not related to dropdown. I think the page width problem is a regression of
Which look like a dirty pollution to existing CSS styles. |
@yp05327 Share link to try page with issue? |
Will be fixed by #24393 (together) At that time, some people do not understand how to make styles work with Fomantic UI correctly. |
Description
It seems that footer has been changed. (In the middle of the footer, not left and right)
Then if we adjust the browser's width:
It seems that there's an issue.
Gitea Version
1.20.0+dev-517-g948a9ee5e
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None
The text was updated successfully, but these errors were encountered: