Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide lastest commit sha when no commit is available #26336

Closed
TheZoker opened this issue Aug 4, 2023 · 0 comments · Fixed by #26340
Closed

Hide lastest commit sha when no commit is available #26336

TheZoker opened this issue Aug 4, 2023 · 0 comments · Fixed by #26340
Labels
type/bug

Comments

@TheZoker
Copy link

TheZoker commented Aug 4, 2023

Description

When I create a new repo without any commit, the Last indexed SHA field looks like this:
image

Just an empty button. I think the button should be hidden, if the content is not available.

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker compose

Database

SQLite
@CaiCandong CaiCandong mentioned this issue Aug 5, 2023
Merged
delvh pushed a commit that referenced this issue Aug 5, 2023
@CaiCandong
Hide last indexed SHA when a repo could not be indexed yet (#26340)
9ac6bb0 
Now, for a new repo without any commit, the Last indexed SHA field looks like this:
Before:
![image](https://github.com/go-gitea/gitea/assets/50507092/cecc6e24-3366-4093-ae07-c361ea34b373)
After: 
![image](https://github.com/go-gitea/gitea/assets/50507092/9b6ba703-b0d5-4648-ad6b-9a2341dd60f9)

Fixes #26336
@GiteaBot GiteaBot mentioned this issue Aug 5, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Aug 5, 2023
@CaiCandong @GiteaBot
Hide last indexed SHA when a repo could not be indexed yet (go-gite…
0bd903d 
…a#26340)

Now, for a new repo without any commit, the Last indexed SHA field looks like this:
Before:
![image](https://github.com/go-gitea/gitea/assets/50507092/cecc6e24-3366-4093-ae07-c361ea34b373)
After: 
![image](https://github.com/go-gitea/gitea/assets/50507092/9b6ba703-b0d5-4648-ad6b-9a2341dd60f9)

Fixes go-gitea#26336
wxiaoguang pushed a commit that referenced this issue Aug 5, 2023
@GiteaBot @CaiCandong
Hide last indexed SHA when a repo could not be indexed yet (#26340) (…
59354d7 
…#26345)

Backport #26340 by @CaiCandong

Now, for a new repo without any commit, the Last indexed SHA field looks
like this:
Before:

![image](https://github.com/go-gitea/gitea/assets/50507092/cecc6e24-3366-4093-ae07-c361ea34b373)
After: 

![image](https://github.com/go-gitea/gitea/assets/50507092/9b6ba703-b0d5-4648-ad6b-9a2341dd60f9)


fix #26336

Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide last indexed SHA when a repo could not be indexed yet CaiCandong/gitea
1 participant
@TheZoker