Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After hiding and unhiding commit checks, there are only four checks available #27928

Closed
lng2020 opened this issue Nov 6, 2023 · 4 comments · Fixed by #27932
Closed

After hiding and unhiding commit checks, there are only four checks available #27928

lng2020 opened this issue Nov 6, 2023 · 4 comments · Fixed by #27932
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@lng2020
Copy link
Member

lng2020 commented Nov 6, 2023

Description

take https://gitea.com/xorm/xorm/pulls/2364 for example.
This PR has eight checks. After hiding and unhiding commit checks, there are only four checks on the web page.
Regression of #26284
cc @yp05327

Screenshots

Before:
before
After:
after

Gitea Version

current main

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

none

@lng2020 lng2020 added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 6, 2023
@lng2020
Copy link
Member Author

lng2020 commented Nov 6, 2023

The scroll bar of these commit lists sometimes messes with the scroll bar of the whole web page. Though failed to find a way to steadily reproduce it.

@lng2020
Copy link
Member Author

lng2020 commented Nov 6, 2023

Perhaps we should not confine the height.

gitea/web_src/css/repo.css

Lines 3082 to 3086 in 8557a94

.commit-status-list {
max-height: 195px; /* fit exactly 4 items */
overflow-x: hidden;
transition: max-height .2s;
}

@wxiaoguang
Copy link
Contributor

-> Fix the overflow style for "Hide all checks" #27932

@silverwind
Copy link
Member

#27932 changes it to 6 visible items.

silverwind added a commit that referenced this issue Nov 7, 2023
Fix #27928

---------

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
Fix go-gitea#27928

---------

Co-authored-by: silverwind <me@silverwind.io>
silverwind added a commit to silverwind/gitea that referenced this issue Feb 20, 2024
Fix go-gitea#27928

---------

Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants