Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX issue] File edit auto-complete shouldn't interfere with typing and instead use a shortcut like shift+enter #28114

Closed
ell1e opened this issue Nov 18, 2023 · 1 comment · Fixed by #30548
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@ell1e
Copy link

ell1e commented Nov 18, 2023

Description

The file edit auto-complete shouldn't interfere with typing and use a shortcut like shift+enter. Auto-completing on enter is a fundamentally disruptive and kind of destructive default, because I may simply want to enter a new line. This is even worse with more free form files like markdown files, where Gitea currently seems to have an autocomplete active, where the suggestions are going to be generally very unhelpful, very random, and I'm way more likely to want to enter a new line than pick any of the auto-complete suggestions.

To make it more discoverable, simply add the shortcut to the popup after changing it to something more sane like shift+enter, like this:

Screenshot from 2023-11-18 17-21-18

Screenshots

Pressing enter here should enter a new line, not write "This" twice:
Screenshot from 2023-11-18 17-21-17

Gitea Version

1.22.0+dev-334-ge88377470

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Linux

Browser Version

Firefox 120.0b9

@ell1e ell1e added topic/ui Change the appearance of the Gitea UI type/bug labels Nov 18, 2023
@ell1e ell1e changed the title [UX issue] File edit auto-complete shouldn't interfere with typing and use a shortcut like shift+enter [UX issue] File edit auto-complete shouldn't interfere with typing and instead use a shortcut like shift+enter Nov 18, 2023
@silverwind
Copy link
Member

To make it more discoverable, simply add the shortcut to the popup after changing it to something more sane like shift+enter

#30548 fixes this. Tab key is to complete suggestions 😉.

silverwind added a commit that referenced this issue Apr 18, 2024
Fixes #28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Apr 18, 2024
…0548)

Fixes go-gitea#28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Apr 18, 2024
…0548)

Fixes go-gitea#28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: Giteabot <teabot@gitea.io>
silverwind added a commit that referenced this issue Apr 18, 2024
…30558)

Backport #30548 by @silverwind

Fixes #28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: silverwind <me@silverwind.io>
silverwind added a commit that referenced this issue Apr 18, 2024
…30559)

Backport #30548 by @silverwind

Fixes #28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: silverwind <me@silverwind.io>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 22, 2024
…30559)

Backport #30548 by @silverwind

Fixes go-gitea/gitea#28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit c9633f2d74490211ffd9fd6b3a17180e86fa1fb9)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 22, 2024
Fixes go-gitea/gitea#28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 49b80f8ac1cf9f0b56da0c73d0f34ef030f4c447)
uli-heller pushed a commit to uli-heller/forgejo that referenced this issue Apr 24, 2024
…30559)

Backport #30548 by @silverwind

Fixes go-gitea/gitea#28114 and behaviour
matches vscode on desktop as well.

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit c9633f2d74490211ffd9fd6b3a17180e86fa1fb9)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants