Viewed files counter is reset when performing a review #28239
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
type/bug
Milestone
Comments
sillyguodong
added
the
issue/confirmed
6543
pushed a commit
that referenced
this issue
Feb 28, 2024
issue : #28239 The counter number script uses the 'checkbox' attribute to determine whether an item is selected or not. However, the input event only increments the counter value, and when more items are displayed, it does not update all previously loaded items. As a result, the display becomes incorrect because it triggers the update counter script, but checkboxes that are selected without the 'checked' attribute are not counted
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Feb 28, 2024
…a#29448) issue : go-gitea#28239 The counter number script uses the 'checkbox' attribute to determine whether an item is selected or not. However, the input event only increments the counter value, and when more items are displayed, it does not update all previously loaded items. As a result, the display becomes incorrect because it triggers the update counter script, but checkboxes that are selected without the 'checked' attribute are not counted
silverwind
pushed a commit
that referenced
this issue
Feb 28, 2024
…#29478) Backport #29448 by @charles7668 issue : #28239 The counter number script uses the 'checkbox' attribute to determine whether an item is selected or not. However, the input event only increments the counter value, and when more items are displayed, it does not update all previously loaded items. As a result, the display becomes incorrect because it triggers the update counter script, but checkboxes that are selected without the 'checked' attribute are not counted Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
|
closed by #29448 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Familiarized with the issue
#26854 ,
#20681
Looks like the problem persists
Gitea Version: 1.21.0
Steps to Replay:
Create a repo
Create a PR with a large number of modified files
Start viewing the PR, marking each viewed file as "viewed" using the checkboxes
Once the first 100 files are marked as viewed, click the "load more" button at the end of the page to load the remaining files
Expected behavior:
100 files are marked as viewed
Viewed files counter at the top of the page displays 100
Actual behavior:
100 files marked as viewed
the viewed files counter at the top of the page displays 0
Gitea Version
1.21.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
1.21.0
Operating System
No response
How are you running Gitea?
Official docker image.
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: