Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orgs/{name}/teams?page={page} return 200 with null\n as content instead of empty list #28420

Closed
YannMagnin opened this issue Dec 11, 2023 · 0 comments · Fixed by #28426
Closed

orgs/{name}/teams?page={page} return 200 with null\n as content instead of empty list #28420

YannMagnin opened this issue Dec 11, 2023 · 0 comments · Fixed by #28426
Labels
type/bug

Comments

@YannMagnin
Copy link

Description

When I try to get teams' information using GET on /orgs/{org}/teams?page={page} with a page that do not exists, the returned status is always 200 with null\n as raw data instead of an empty list.

Gitea Version

1.21.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Linux Mint, EndeavourOS

How are you running Gitea?

Official binaries, and running from systemd and command-line

Database

SQLite
@KN4CK3R KN4CK3R mentioned this issue Dec 11, 2023
Merged
lunny pushed a commit that referenced this issue Jan 11, 2024
@KN4CK3R
Fix convert.ToTeams on empty input (#28426)
595a929 
Fixes #28420

Don't return `nil` if the input was empty.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 11, 2024
@KN4CK3R @GiteaBot
Fix convert.ToTeams on empty input (go-gitea#28426)
babe9c2 
Fixes go-gitea#28420

Don't return `nil` if the input was empty.
@GiteaBot GiteaBot mentioned this issue Jan 11, 2024
Merged
lunny pushed a commit that referenced this issue Jan 12, 2024
@GiteaBot @KN4CK3R
Fix convert.ToTeams on empty input (#28426) (#28767)
95901a9 
Backport #28426 by @KN4CK3R

Fixes #28420

Don't return `nil` if the input was empty.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@KN4CK3R @fuxiaohei
Fix convert.ToTeams on empty input (go-gitea#28426)
276b0fd 
Fixes go-gitea#28420

Don't return `nil` if the input was empty.
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@KN4CK3R @silverwind
Fix convert.ToTeams on empty input (go-gitea#28426)
4e33018 
Fixes go-gitea#28420

Don't return `nil` if the input was empty.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix convert.ToTeams on empty input KN4CK3R/gitea
1 participant
@YannMagnin