MINIMUM_KEY_SIZE_CHECK value wrongly evaluated #28451
Labels
Milestone
Comments
|
I thought I understood it wrong, but it seems I still was right. Setting the option Aside from it being worded completely confusing, it's evaluated wrongly too. |
|
Regression of #13860 The old code has commented out the code.
Actually IMO this code block could (should) be removed completely, because there is another code block below:
|
wxiaoguang
added a commit
that referenced
this issue
Dec 17, 2023
…ys (#28492) Resolves #28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this issue
Jan 17, 2024
…ys (go-gitea#28492) Resolves go-gitea#28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
…ys (go-gitea#28492) Resolves go-gitea#28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this issue
Mar 23, 2024
…ys (go-gitea#28492) Resolves go-gitea#28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Hey,
when
MINIMUM_KEY_SIZE_CHECK = truein the config (default), the UI settings will say:Which is false. Turning the option off will place a checkmark in place of the 'option disabled' icon.
I think the configuration option is badly evaluated and thus confusing. Or the option description is worded wrongly.
Gitea Version
1.21.2
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
irrelevant
How are you running Gitea?
In a FreeBSD jail.
Database
MySQL/MariaDB
The text was updated successfully, but these errors were encountered: