Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing of spent time in Issue activity results in 404 if time tracking is disabled #29233

Closed
Beat2er opened this issue Feb 18, 2024 · 0 comments · Fixed by #29257
Closed

Removing of spent time in Issue activity results in 404 if time tracking is disabled #29233

Beat2er opened this issue Feb 18, 2024 · 0 comments · Fixed by #29257
Assignees
@Zettat123
Labels
type/bug
Milestone
1.21.6

Comments

@Beat2er
Copy link

Beat2er commented Feb 18, 2024

Description

If time was tracked and then time tracking is disabled (in my case at repo scope) the frontend still allows for deletion of the time log. this results in a 404. if time tracking is enabled again, this endpoint now works.
Url of endpoint: https://gitea.local/ORG/repo/issues/1/times/1/delete
Maybe remove time tracking

  • deletion
  • in general

from the frontend if disabled.

I wasn't able to use https://try.gitea.io/ for reproduction, as it's login seems to be down

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image
image

Git Version

No response

Operating System

Windows Server

How are you running Gitea?

Standalone windows

Database

MSSQL
@Zettat123 Zettat123 self-assigned this Feb 19, 2024
@Zettat123 Zettat123 mentioned this issue Feb 19, 2024
Merged
@lunny lunny added this to the 1.21.6 milestone Feb 19, 2024
lunny pushed a commit that referenced this issue Feb 20, 2024
@Zettat123
Do not show delete button when time tracker is disabled (#29257)
8c21bc0 
Fix #29233

The delete button of time logs won't be shown when the time tracker is disabled.
 
![image](https://github.com/go-gitea/gitea/assets/15528715/5cc4e0c9-d2f9-4b8f-a2f5-fe202b94c191)
Zettat123 added a commit to Zettat123/gitea that referenced this issue Feb 20, 2024
@Zettat123
Do not show delete button when time tracker is disabled (go-gitea#29257)
9a26717 
Fix go-gitea#29233

The delete button of time logs won't be shown when the time tracker is disabled.
 
![image](https://github.com/go-gitea/gitea/assets/15528715/5cc4e0c9-d2f9-4b8f-a2f5-fe202b94c191)
@Zettat123 Zettat123 mentioned this issue Feb 20, 2024
Merged
KN4CK3R added a commit that referenced this issue Feb 20, 2024
@Zettat123 @KN4CK3R
Do not show delete button when time tracker is disabled (#29257) (#29279
e940443 
)

Backport #29257 
Fix #29233

The delete button of time logs won't be shown when the time tracker is
disabled.
 

![image](https://github.com/go-gitea/gitea/assets/15528715/5cc4e0c9-d2f9-4b8f-a2f5-fe202b94c191)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@Zettat123 @silverwind
Do not show delete button when time tracker is disabled (go-gitea#29257)
7f45663 
Fix go-gitea#29233

The delete button of time logs won't be shown when the time tracker is disabled.
 
![image](https://github.com/go-gitea/gitea/assets/15528715/5cc4e0c9-d2f9-4b8f-a2f5-fe202b94c191)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Zettat123 Zettat123

Labels
type/bug
Projects
None yet
Milestone
1.21.6
Development

Successfully merging a pull request may close this issue.

Do not show delete button when time tracker is disabled Zettat123/gitea
3 participants
@lunny @Zettat123 @Beat2er