Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app.ini seems like missing one line #29510

Closed
Origami404 opened this issue Mar 1, 2024 · 1 comment · Fixed by #29511
Closed

The app.ini seems like missing one line #29510

Origami404 opened this issue Mar 1, 2024 · 1 comment · Fixed by #29511
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/docs This PR mainly updates/creates documentation

Comments

@Origami404
Copy link
Contributor

Description

Hello, as I was carefully reading through all the options in app.ini, I noticed that this line seems to be off. It appears to be a description of a configuration item, but the next line doesn't have a corresponding configuration item.

Link:

gitea/custom/conf/app.example.ini

Line 958 in 58ce1de

;; Close issues as long as a commit on any branch marks it as fixed

Gitea Version

58ce1de

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Not related.

Database

None
@wxiaoguang
Copy link
Contributor

Good catch! The content should be

; Close issues as long as a commit on any branch marks it as fixed
DEFAULT_CLOSE_ISSUES_VIA_COMMITS_IN_ANY_BRANCH = false
; Allow users to push local repositories to Gitea and have them automatically created for a user or an org
ENABLE_PUSH_CREATE_USER = false
ENABLE_PUSH_CREATE_ORG = false

(regression of #15807)

@Origami404 Origami404 mentioned this issue Mar 1, 2024
Merged
@wxiaoguang wxiaoguang added type/docs This PR mainly updates/creates documentation issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented good first issue Likely to be an easy fix and removed good first issue Likely to be an easy fix labels Mar 1, 2024
wxiaoguang added a commit that referenced this issue Mar 1, 2024
@Origami404 @techknowlogick
@lunny @wxiaoguang
Adding back missing options to app.example.ini (#29511)
2ca5daf 
In the refactoring of the configuration file #15807,
some lines were accidentally deleted:

DEFAULT_CLOSE_ISSUES_VIA_COMMITS_IN_ANY_BRANCH = false
ENABLE_PUSH_CREATE_USER = false
ENABLE_PUSH_CREATE_ORG = false

Fix #29510

---------

Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding back missing options to app.example.ini Origami404/gitea
2 participants
@wxiaoguang @Origami404