Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea Scrollbar is ugly (again) #29652

Closed
mrexodia opened this issue Mar 8, 2024 · 7 comments · Fixed by #29800
Closed

Gitea Scrollbar is ugly (again) #29652

mrexodia opened this issue Mar 8, 2024 · 7 comments · Fixed by #29800
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI

Comments

@mrexodia
Copy link
Contributor

mrexodia commented Mar 8, 2024

Description

Apparently Chrome started supporting scrollbar-color and now Gitea looks ugly:

image

Gitea Version

1.22.0+dev-969-g26653b196

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

It reproduces in try.gitea.io

Database

None

@lunny lunny added topic/ui Change the appearance of the Gitea UI and removed type/bug labels Mar 8, 2024
@silverwind
Copy link
Member

silverwind commented Mar 8, 2024

I would say the rendering is expected, at least that's how Firefox has been rendering for a long time now. Question is thought, whether we should do away with the scrollbar coloring completely.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 8, 2024

Question is thought, whether we should do away with the scrollbar coloring completely.

Yes, please 🙏

@silverwind silverwind added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Mar 8, 2024
@silverwind
Copy link
Member

silverwind commented Mar 8, 2024

Waiting for more feedback. ❤️ or 👎 above post please whether you want custom scrollbar colors or not. Personally I don't care as MacOS overlay scrollbars are always native.

@ExplodingDragon
Copy link
Contributor

firefox style looks good , maybe it can be emulated in chrome.
图片

@silverwind
Copy link
Member

silverwind commented Mar 9, 2024

I think the vote clearly shows that people prefer default scrollbars. We shouldn't try to "emulate" anything. Let the browser decide. Can always be changed with a userstyle if people prefer.

@aceArt-GmbH
Copy link
Contributor

Chrome just got support for standard scroll bar styling https://caniuse.com/?search=scrollbar-color

@silverwind
Copy link
Member

#29800

techknowlogick pushed a commit that referenced this issue Mar 15, 2024
Fixes #29652. Removes all
scrollbar customization as per popular vote on
#29652 (comment).

There is one more case of `-webkit-scrollbar` left in CSS and
#29400 will get rid of that as
well.
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 20, 2024
Fixes go-gitea/gitea#29652. Removes all
scrollbar customization as per popular vote on
go-gitea/gitea#29652 (comment).

There is one more case of `-webkit-scrollbar` left in CSS and
go-gitea/gitea#29400 will get rid of that as
well.

(cherry picked from commit 0827552d9ab6bec5fccef86139cbad3ae7b582b7)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants