Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author name not in the middle in commit list page #30129

Closed
yp05327 opened this issue Mar 27, 2024 · 5 comments · Fixed by #30396
Closed

Author name not in the middle in commit list page #30129

yp05327 opened this issue Mar 27, 2024 · 5 comments · Fixed by #30396
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Mar 27, 2024

Description

#29989 (comment)

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@lunny
Copy link
Member

lunny commented Mar 27, 2024

I don't think it's a bug. I think it's OK to not vertical center aligned.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 27, 2024

Before #29989, it was. So the behavior changed unexpected, as this PR is just for fixing different username color.

@silverwind
Copy link
Member

I guess we can fix it.

@silverwind
Copy link
Member

silverwind commented Mar 27, 2024 •
edited
Loading

@yp05327 it seems best to revert tw-flex because table cells with display: flex behave strangely and cannot be vertically centered through the usual methods. Can you try solving the whitespace issue by just removing it in the HTML template instead where appropriate, or give me reproduction steps for this issue with the whitespace?

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 9, 2024 •
edited
Loading

In template, there was no whitespace, but in browser, there was.
And I don't know why, now I can't see whitespace. 😕
image

ps: the repo is a mirror of https://gitea.com/gitea/act_runner

@silverwind silverwind mentioned this issue Apr 10, 2024
Merged
lunny pushed a commit that referenced this issue Apr 11, 2024
@silverwind
Fix author name alignment in commits table (#30396)
50dbed6 
Fixes #30129 by introducing a
wrapper div with flexbox that collapses any inter-tag whitespace within.
View diff with whitespace hidden.

Author names aligned:
<img width="172" alt="Screenshot 2024-04-10 at 19 41 27"
src="https://github.com/go-gitea/gitea/assets/115237/d761e8f2-0e67-4f84-8d37-9ed73850470a">

Vertically centered on expand:
<img width="466" alt="Screenshot 2024-04-10 at 19 43 02"
src="https://github.com/go-gitea/gitea/assets/115237/decd68b3-19b5-4cfa-a505-b358e4a0715b">

Ellipsis works:

<img width="344" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/6f8624a2-f8b6-4f3e-ac98-c44dd0cdfca5">
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 16, 2024
@silverwind @Gusted
[PORT] gitea#30396: Fix author name alignment in commits table
6ece8c0 
Fixes go-gitea/gitea#30129 by introducing a
wrapper div with flexbox that collapses any inter-tag whitespace within.
View diff with whitespace hidden.

Author names aligned:
<img width="172" alt="Screenshot 2024-04-10 at 19 41 27"
src="https://github.com/go-gitea/gitea/assets/115237/d761e8f2-0e67-4f84-8d37-9ed73850470a">

Vertically centered on expand:
<img width="466" alt="Screenshot 2024-04-10 at 19 43 02"
src="https://github.com/go-gitea/gitea/assets/115237/decd68b3-19b5-4cfa-a505-b358e4a0715b">

Ellipsis works:

<img width="344" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/6f8624a2-f8b6-4f3e-ac98-c44dd0cdfca5">

---

Conflict resolution: Trivial
(cherry picked from commit 50dbed652738182eb42af51967ec7bd10e84ede9)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix author name alignment in commits table silverwind/gitea
3 participants
@lunny @silverwind @yp05327