Can not view code in pr when change a lot

[seepine]

Description

hidden when change a lot, but click view 404.

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

MySQL/MariaDB

[kemzeb]

Thanks for the bug report. Can you provide some more details and steps to reproduce the problem?

[GiteaBot]

We close issues that need feedback from the author if there were no new comments for a month. 🍵

[seepine]

Preface

A create private repo a/demo.
B fork repo b/demo and update index.js,then create pr to a/demo with checked.

Situation

A review the pr.

And got 404 from view or edit.

Expect

If not permission, maybe hide the view and edit button.

[Zettat123]

Since "Allow maintainers to edit" is enabled, user A should have permission to view and edit the PR files. So I think in this case we should not hide the button but should allow maintainers to view and edit the files

[Zettat123]

This feature was introduced by #18002. From its description we can see

edit/delete/upload files via web UI

However, I did some testing and found that when the forked repo is private, performing these operations via the web UI results in the 404 page. Maybe we need to improve the middleware to allow maintainers to access these pages.